Simplify dropdims(::Transpose)
and insertdims(::PermutedDimsArray)
etc.
#55381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, these wrap the wrapper in a ReshapedArray:
After:
This is not always faster, alone, but the hope is that the simpler return type will usually be faster downstream. (Especially with e.g.
CuArray
s, where wrapping twice causes them to miss specialised methods.)It appears that the compiler can predict the type when
dims
is constant. More stringent tests (or ways to do better) would be welcome: