From 840932f350875856b108c63e1fb726166295cfbf Mon Sep 17 00:00:00 2001
From: oscarddssmith <oscar.smith@juliacomputing.com>
Date: Wed, 17 Apr 2024 09:20:07 -0400
Subject: [PATCH] Make redefining const globals into an error

---
 doc/src/manual/variables-and-scoping.md | 74 ++-----------------------
 src/module.c                            |  5 +-
 2 files changed, 5 insertions(+), 74 deletions(-)

diff --git a/doc/src/manual/variables-and-scoping.md b/doc/src/manual/variables-and-scoping.md
index e921ed8931e84..4a368b0eba28a 100644
--- a/doc/src/manual/variables-and-scoping.md
+++ b/doc/src/manual/variables-and-scoping.md
@@ -686,27 +686,16 @@ Special top-level assignments, such as those performed by the `function` and `st
 are constant by default.
 
 Note that `const` only affects the variable binding; the variable may be bound to a mutable
-object (such as an array), and that object may still be modified. Additionally when one tries
-to assign a value to a variable that is declared constant the following scenarios are possible:
-
-* if a new value has a different type than the type of the constant then an error is thrown:
+object (such as an array), and that object may still be modified. When one tries to assign a
+value to a variable that is declared constant an error is thrown
+ unless assignment would not result in the change of variable:
 ```jldoctest
 julia> const x = 1.0
 1.0
 
-julia> x = 1
+julia> x = 1.3
 ERROR: invalid redefinition of constant x
 ```
-* if a new value has the same type as the constant then a warning is printed:
-```jldoctest
-julia> const y = 1.0
-1.0
-
-julia> y = 2.0
-WARNING: redefinition of constant y. This may fail, cause incorrect answers, or produce other errors.
-2.0
-```
-* if an assignment would not result in the change of variable value no message is given:
 ```jldoctest
 julia> const z = 100
 100
@@ -714,61 +703,6 @@ julia> const z = 100
 julia> z = 100
 100
 ```
-The last rule applies to immutable objects even if the variable binding would change, e.g.:
-```julia-repl
-julia> const s1 = "1"
-"1"
-
-julia> s2 = "1"
-"1"
-
-julia> pointer.([s1, s2], 1)
-2-element Array{Ptr{UInt8},1}:
- Ptr{UInt8} @0x00000000132c9638
- Ptr{UInt8} @0x0000000013dd3d18
-
-julia> s1 = s2
-"1"
-
-julia> pointer.([s1, s2], 1)
-2-element Array{Ptr{UInt8},1}:
- Ptr{UInt8} @0x0000000013dd3d18
- Ptr{UInt8} @0x0000000013dd3d18
-```
-However, for mutable objects the warning is printed as expected:
-```jldoctest
-julia> const a = [1]
-1-element Vector{Int64}:
- 1
-
-julia> a = [1]
-WARNING: redefinition of constant a. This may fail, cause incorrect answers, or produce other errors.
-1-element Vector{Int64}:
- 1
-```
-
-Note that although sometimes possible, changing the value of a `const` variable is strongly
-discouraged, and is intended only for convenience during interactive use. Changing constants can
-cause various problems or unexpected behaviors. For instance, if a method references a constant and
-is already compiled before the constant is changed, then it might keep using the old value:
-
-```jldoctest
-julia> const x = 1
-1
-
-julia> f() = x
-f (generic function with 1 method)
-
-julia> f()
-1
-
-julia> x = 2
-WARNING: redefinition of constant x. This may fail, cause incorrect answers, or produce other errors.
-2
-
-julia> f()
-1
-```
 
 ## [Typed Globals](@id man-typed-globals)
 
diff --git a/src/module.c b/src/module.c
index 702c98f165782..aefeb8bc9f87d 100644
--- a/src/module.c
+++ b/src/module.c
@@ -908,11 +908,8 @@ jl_value_t *jl_check_binding_wr(jl_binding_t *b, jl_module_t *mod, jl_sym_t *var
             }
             if (jl_egal(rhs, old))
                 return NULL;
-            if (jl_typeof(rhs) != jl_typeof(old) || jl_is_type(rhs) || jl_is_module(rhs))
-                reassign = 0;
             else
-                jl_safe_printf("WARNING: redefinition of constant %s.%s. This may fail, cause incorrect answers, or produce other errors.\n",
-                               jl_symbol_name(mod->name), jl_symbol_name(var));
+                reassign = 0;
         }
         if (!reassign)
             jl_errorf("invalid redefinition of constant %s.%s",