Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 [master] Bump the Pkg stdlib from 85f1e5564 to 3c86ba27e #52595

Merged

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 85f1e5564
New commit: 3c86ba27e
Julia version: 1.11.0-DEV
Pkg version: 1.11.0
Bump invoked by: @IanButterworth
Powered by: BumpStdlibs.jl

Diff: JuliaLang/Pkg.jl@85f1e55...3c86ba2

$ git log --oneline 85f1e5564..3c86ba27e
3c86ba27e add `add --weak/extra Foo` to add to [weakdeps] or [extras] (#3708)
2e640f92f respect --color=no in Pkg.precompile (#3740)
cbd5d08ad Automatically add compat entries when adding deps to a package (#3732)
03de920b3 rm old manual handling of `--compiled-modules` (#3738)
314d5497b Use realpaths for temp dirs during tests. Fix SparseArrays `why` breakage (#3734)
a6531d4be environments.md: update Julia version (#3715)
a509bc062 Revise the API of is_manifest_current. (#3701)
60b7b7995 rm incorrect kwargs in add docstring (#3733)

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Dec 20, 2023
@Keno Keno merged commit 0cac28c into JuliaLang:master Dec 21, 2023
6 of 8 checks passed
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Dec 21, 2023
@DilumAluthge DilumAluthge deleted the BumpStdlibs/Pkg-3c86ba27e-master branch December 21, 2023 03:59
@fingolfin
Copy link
Member

I wonder if this is the source of the new CI failures we see when testing against Julia nightly (e.g. here:

ERROR: LoadError: InitError: MethodError: no method matching is_manifest_current()

Closest candidates are:
  is_manifest_current(::Pkg.Types.Context)
   @ Pkg /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:458
  is_manifest_current(::AbstractString)
   @ Pkg /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:459

@fingolfin
Copy link
Member

Sorry, I am wrong, this is entirely our own fault. So just ignore my remark above

@IanButterworth
Copy link
Member

Are you sure? We changed the api of is_manifest_current because the previous no arg method was most likely going to be misused in package tests. That Pkg PR should have a news entry if it doesn't already. I didn't find any public users of that function so I thought it wouldn't need deprecating, but we could deprecate with an explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants