-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Base.lib{blas,lapack}_name
#50699
base: master
Are you sure you want to change the base?
Conversation
I think we definitely need to run PkgEval on this, to find more examples such as: JuliaLinearAlgebra/BandedMatrices.jl#386 |
80aad5b
to
9406741
Compare
I believe the decision from the last time was that removing these caused a lot of breakage. It does seem that most packages have been updated to avoid using the old names. Are we good to merge this now? |
These have been deprecated for a long time, users should instead use `LinearAlgebra.BLAS.libblas` or `LinearAlgebra.BLAS.liblapack`. This will be necessary once we have lazy JLLs, as it's not desirable to recreate the dependency graph in `Base`, we already have it in standard libraries, and only load libblastrampoline when `LinearAlgebra` starts doing ccalls.
e6a83c4
to
090739d
Compare
Let's run PkgEval on it, just to see if the breakage is contained enough now. @nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. |
Looks like 70 odd packages still have |
….libblas_name` This change is in support of JuliaLang/julia#50699
….liblapack_name` This change is in support of JuliaLang/julia#50699
It turns out that almost all of them are all due to PR checklist: |
….liblapack_name` (#14) This change is in support of JuliaLang/julia#50699
….libblas_name` (#589) This change is in support of JuliaLang/julia#50699
These have been deprecated for a long time, users should instead use
LinearAlgebra.BLAS.libblas
orLinearAlgebra.BLAS.liblapack
.This will be necessary once we have lazy JLLs, as it's not desirable to
recreate the dependency graph in
Base
, we already have it in standardlibraries, and only load libblastrampoline when
LinearAlgebra
startsdoing ccalls.