Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some invalidations when loading Static.jl #46553

Merged
merged 4 commits into from
Sep 6, 2022
Merged

fix some invalidations when loading Static.jl #46553

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b3a3ae
improve type stability of `mightalias(A::AbstractArray, B::AbstractAr…
ranocha Aug 30, 2022
a42af13
Revert "improve type stability of `mightalias(A::AbstractArray, B::Ab…
ranocha Aug 31, 2022
8bbc8a0
improve type stability of `findall(testf::Function, A::AbstractArray)`
ranocha Aug 31, 2022
71ba31d
improve type stability of `findall(testf::Function, A::AbstractArray)`
ranocha Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/abstractarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1492,7 +1492,7 @@ Perform a conservative test to check if arrays `A` and `B` might share the same
By default, this simply checks if either of the arrays reference the same memory
regions, as identified by their [`Base.dataids`](@ref).
"""
mightalias(A::AbstractArray, B::AbstractArray) = !isbits(A) && !isbits(B) && !_isdisjoint(dataids(A), dataids(B))
mightalias(A::AbstractArray, B::AbstractArray) = !(isbits(A)::Bool) && !(isbits(B)::Bool) && !_isdisjoint(dataids(A), dataids(B))
mightalias(x, y) = false

_isdisjoint(as::Tuple{}, bs::Tuple{}) = true
Expand Down