-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PhiNode
with edge==0
#46388
Merged
Merged
Handle PhiNode
with edge==0
#46388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
added
bugfix
This change fixes an existing bug
compiler:inference
Type inference
backport 1.6
Change should be backported to release-1.6
backport 1.8
Change should be backported to release-1.8
labels
Aug 18, 2022
Keno
approved these changes
Aug 18, 2022
35 tasks
78 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6
Change should be backported to release-1.6
bugfix
This change fixes an existing bug
compiler:inference
Type inference
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure this makes sense. Maybe we shouldn't produce
PhiNode
s with an edge of 0 in the first place (inserting a dummy instruction as first BB before it instead or something). But I do get the same@code_llvm
forf() = while true x = try finally end end
andg() = (nothing; while true x = try finally end end)
, where before, inference off()
would give an internal error. Also, I note that once upon a time, we used to do something similar:julia/base/compiler/ssair/legacy.jl
Lines 197 to 201 in 61b75ef
I'm not sure a
0
-edge might cause trouble elsewhere, though. But then again, it would not have worked at all before and did not seem to cause too much trouble, so thosePhiNode
s seem to be quite rare, and at least the case at hand is fixed by this.Fixes #45600.