Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve partial opaque inference #45782

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

oscardssmith
Copy link
Member

closes #45780

@oscardssmith oscardssmith added the compiler:inference Type inference label Jun 22, 2022
test/compiler/inference.jl Outdated Show resolved Hide resolved
@Keno
Copy link
Member

Keno commented Jun 22, 2022

Could use a more extensive commit message, at least referencing the commit that added the tmeet call in the abstract interpretation for :new.

@oscardssmith
Copy link
Member Author

Is this ready to merge? (I'll fix the commit message in the squash if so)

@oscardssmith oscardssmith merged commit aa17702 into master Jun 23, 2022
@oscardssmith oscardssmith deleted the oscardssmith-PartialOpaque-inference branch June 23, 2022 20:15
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
improve opaqueclosure inference 
JuliaLang#42831 started calling `tmeet` in abstractinterpretation of `:new` which meant that we now need to be able to infer it.
Co-authored-by: Keno Fischer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference quality regression with opaque closures
4 participants