Pass along backlog keyword argument in Sockets.listen #45737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Jun 19, 2022
| @@ -625,7 +625,7 @@ listen(port::Integer; backlog::Integer=BACKLOG_DEFAULT) = listen(localhost, port | |||
| listen(host::IPAddr, port::Integer; backlog::Integer=BACKLOG_DEFAULT) = listen(InetAddr(host, port); backlog=backlog) | |||
|
|
|||
| function listen(sock::LibuvServer; backlog::Integer=BACKLOG_DEFAULT) | |||
| uv_error("listen", trylisten(sock)) | |||
| uv_error("listen", trylisten(sock; backlog=backlog)) | |||
There was a problem hiding this comment.
Can also use the shorter
Suggested change
| uv_error("listen", trylisten(sock; backlog=backlog)) | |
| uv_error("listen", trylisten(sock; backlog)) |
fredrikekre
added
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 4f1c68e)
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit 4f1c68e)
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit 4f1c68e)
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit 4f1c68e)
This was referenced Jul 5, 2022
KristofferC
removed
backport 1.8
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 4f1c68e)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 4f1c68e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not crazy right? This is just not getting passed through?