Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also set the version in pkgorigins #44318

Merged
merged 1 commit into from
Feb 24, 2022
Merged

also set the version in pkgorigins #44318

merged 1 commit into from
Feb 24, 2022

Conversation

KristofferC
Copy link
Member

This will be used for Pkg to understand when external packages are put into the sysimage and thereby are effectively "pinned" to that version.

@KristofferC KristofferC requested a review from timholy February 23, 2022 19:12
@vtjnash
Copy link
Member

vtjnash commented Feb 23, 2022

@KristofferC
Copy link
Member Author

This feels quite uncontroversial so I'll just merge it.

@KristofferC KristofferC merged commit 21e5a26 into master Feb 24, 2022
@KristofferC KristofferC deleted the kc/pkgorigin_version branch February 24, 2022 21:35
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
simonbyrne added a commit that referenced this pull request May 11, 2022
On 1.7 and 1.8, if you provide a directory to `env_project_file`, it will return `true` even if there is a project file in the directory.

Note that this PR is against the release-1.8: it was fixed on master by #44318, so we could also backport that one.
KristofferC pushed a commit that referenced this pull request May 12, 2022
On 1.7 and 1.8, if you provide a directory to `env_project_file`, it will return `true` even if there is a project file in the directory.

Note that this PR is against the release-1.8: it was fixed on master by #44318, so we could also backport that one.
KristofferC pushed a commit that referenced this pull request May 12, 2022
On 1.7 and 1.8, if you provide a directory to `env_project_file`, it will return `true` even if there is a project file in the directory.

Note that this PR is against the release-1.8: it was fixed on master by #44318, so we could also backport that one.
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Jun 7, 2022
KristofferC added a commit that referenced this pull request Jun 7, 2022
@KristofferC KristofferC mentioned this pull request Jun 7, 2022
36 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants