Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #42152 to 1.7 #42828

Merged

Conversation

barche
Copy link
Contributor

@barche barche commented Oct 27, 2021

#42152

I hope this doesn't break anything 😬

@vchuravy vchuravy requested a review from vtjnash October 27, 2021 20:03
@barche
Copy link
Contributor Author

barche commented Oct 28, 2021

I think the failures are related to some temporary problem with a http test server?

Error in testset Downloads:
Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\stdlib\v1.7\Downloads\test\runtests.jl:323
  Expression: resp.url == url
   Evaluated: "https://httpbingo.julialang.org/image/jpeg" == "https://httpbingo.julialang.org/status/300"
Error in testset Downloads:
Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\stdlib\v1.7\Downloads\test\runtests.jl:324
  Expression: resp.status == status
   Evaluated: 200 == 300
Error in testset Downloads:
Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\stdlib\v1.7\Downloads\test\setup.jl:48
  Expression: parse(Int, m.captures[1]) == status
   Evaluated: 200 == 300

@KristofferC KristofferC reopened this Oct 28, 2021
@DilumAluthge
Copy link
Member

Maybe needs a rebase? The httpbingo failures were fixed by #42816

@barche barche force-pushed the backport-1.7-42152 branch from 4e25d20 to a8b0653 Compare October 28, 2021 20:40
@barche
Copy link
Contributor Author

barche commented Oct 29, 2021

Maybe needs a rebase? The httpbingo failures were fixed by #42816

Yes, that did the trick, thanks! No idea about the two remaining failures though.

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 29, 2021

@vchuravy @staticfloat What's going on with analyzegc here?

Note that analyzegc is passing on backports-release-1.7 (#42765), so I think the problem is somewhere in this PR.

@DilumAluthge
Copy link
Member

Same question about embedding, which is passing on backport-release-1.7, but failing on this PR.

I reran the jobs, but they are still failing.

@DilumAluthge
Copy link
Member

Might also need @vtjnash's help.

@DilumAluthge
Copy link
Member

I wonder if there are some other PRs that have modified the analyzegc and embedding code, that we will also need to backport in order to make this work.

@DilumAluthge DilumAluthge added the release Release management and versioning. label Oct 29, 2021
src/Makefile Outdated Show resolved Hide resolved
@barche
Copy link
Contributor Author

barche commented Oct 29, 2021

There is another error in the makefile, will fix it soon.

@barche
Copy link
Contributor Author

barche commented Oct 30, 2021

The only remaining error is from freebsd:

fcntl(): Bad file descriptor
-p: not found

No idea what it means...

@DilumAluthge
Copy link
Member

I restarted the package_freebsd64 job, and it is passing now.

You can ignore the tester_freebsd64 failure, as long as the package_freebsd64 job is passing.

@DilumAluthge DilumAluthge requested review from KristofferC and vtjnash and removed request for vtjnash October 30, 2021 23:31
@KristofferC KristofferC merged commit d7ccfd2 into JuliaLang:backports-release-1.7 Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants