Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse unicode forall and exists as identifiers #42314

Merged
merged 9 commits into from
Oct 4, 2021
Merged

parse unicode forall and exists as identifiers #42314

merged 9 commits into from
Oct 4, 2021

Conversation

willow-ahrens
Copy link
Contributor

@willow-ahrens willow-ahrens commented Sep 19, 2021 •
edited
Loading

A proposed fix to to #19012, allowing ∀ and ∃ to be parsed as identifier characters, just like ∑, ∫, ⋃, or Π.

@stevengj stevengj added needs news A NEWS entry is required for this change parser Language parsing and surface syntax unicode Related to unicode characters and encodings labels Sep 19, 2021
@stevengj
Copy link
Member

I'm in favor. No one has proposed a convincing infix usage for these AFAICT.

stevengj
stevengj reviewed Sep 20, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@stevengj stevengj removed the needs news A NEWS entry is required for this change label Sep 20, 2021
@willow-ahrens @stevengj
add pr to news
319d27c 
Co-authored-by: Steven G. Johnson <[email protected]>
@JeffBezanson JeffBezanson added the triage This should be discussed on a triage call label Sep 20, 2021
@JeffBezanson
Copy link
Member

Triage approves, and suggests adding U+2204 "there does not exist" as well.

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Sep 30, 2021
@willow-ahrens
Copy link
Contributor Author

I've added the "not exists" (∄) character. I was unable to find a "not forall" character, and upon reflection, I'm unsure what it would even look like.

@willow-ahrens
Copy link
Contributor Author

To make the conclusion of my last comment a little more clear: I believe this PR is ready for another review or a merge.

@vchuravy vchuravy merged commit 690517a into JuliaLang:master Oct 4, 2021
@willow-ahrens willow-ahrens mentioned this pull request Oct 7, 2021
Closed
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@willow-ahrens @stevengj @LilithHafner
parse unicode forall and exists as identifiers (JuliaLang#42314)
e1764c3 
Co-authored-by: Steven G. Johnson <[email protected]>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@willow-ahrens @stevengj @LilithHafner
parse unicode forall and exists as identifiers (JuliaLang#42314)
e6876b3 
Co-authored-by: Steven G. Johnson <[email protected]>
@savq savq mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
parser Language parsing and surface syntax unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willow-ahrens @stevengj @JeffBezanson @vchuravy