[LinearAlgebra] Correct liblapack binding

[lkapelevich]

addresses #39845 (comment)

[fredrikekre]

liblapack was defined in LinearAlgebra.BLAS too:

julia/stdlib/LinearAlgebra/src/blas.jl

Lines 66 to 67 in e66a39b

	const libblas = Base.libblas_name
	const liblapack = Base.liblapack_name

, so I think that one should be kept and you should only add the binding to LinearAlgebra.LAPACK:

julia/stdlib/LinearAlgebra/src/lapack.jl

Line 8 in e66a39b

const liblapack = Base.liblapack_name

[ViralBShah]

@fredrikekre I suppose ideally we should remove the liblapack from LinearAlgebra.BLAS, but are we retaining it because things might depend on it?

[fredrikekre]

Yes, I thought that was the point of #39845.

[ViralBShah]

Yes, I thought that was the point of #39845.

Yes, that is right. I just looked, and we do have liblapack currently defined in blas.jl on release-1.6. I am guessing it would be ok to move it to the LAPACK module and most likely will lead to very little breakage. Most packages care about BLAS and overriding it and much less so with LAPACK.

What do you think about having only libblas in blas.jl, and liblapack in lapack.jl - and then running the pkgeval to see how breaking it is?

[fredrikekre]

Sure, but costs nothing to keep them. Doesn't even seem like they had to be renamed in the first place.

[KristofferC]

I don't think this is relevant for 1.6?