-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Core._apply Builtin #39115
remove Core._apply Builtin #39115
Conversation
We can emulate this deprecated function, until we delete it in v2. This in turn revealed some missing error checks, which we also add. Fixes #39113
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
This seems like it should be removable: it's not exported and it starts with |
Should this also be backported then? |
While it might not be covered by semver, there are still a lot of packages using it: https://juliahub.com/ui/CodeSearch?q=_apply&u=all&t=all. I don't see any issues with just keeping it for 1.x, so I don't think there's reason enough to break a bunch of code by removing it. |
Yeah, we can't remove it. This fallback might be ok though. |
Why can't we remove it? |
Because it would be extremely breaking for no reason. This used to be inserted by the frontend, so it has propagated far and wide. It's also inside things like serialized closures inside Flux model files. |
Looks great. The only failure this causes is Zygote, where we fixed a test_broken. GTG. |
Doesn't backport cleanly and my attempts at fixing it still errors. Can push a rebased commit to #39160. |
We can emulate this deprecated function, until we delete it in v2. This in turn revealed some missing error checks, which we also add. Fixes JuliaLang#39113
We can emulate this deprecated function, until we delete it in v2.
This in turn revealed some missing error checks, which we also add.
Fixes #39113