-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small perf enhancement for deserialize of Arrays #18583
Conversation
cc0534b
to
c2b43c3
Compare
Array(Type, dims) is very hard (expensive) to dispatch
c2b43c3
to
636f1e4
Compare
do we have any deserialization benchmarks? @nanosoldier |
Cc @kpamnany @jeff-regier Perhaps we can adapt the use case from Celeste.jl as a standalone deserialize benchmark. Would really help catch future regressions. |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
It looks like the parallel::remotecall perf test may lightly involve this |
See #18633 for a small benchmark. |
Array(Type, dims) is very hard (expensive) to dispatch (cherry picked from commit 636f1e4)
Array(Type, dims)
is very hard (expensive) to dispatch, so this makes the constructor call a leaftype first to make it cheaper