Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small perf enhancement for deserialize of Arrays #18583

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 19, 2016

Array(Type, dims) is very hard (expensive) to dispatch, so this makes the constructor call a leaftype first to make it cheaper

@vtjnash vtjnash force-pushed the jn/faster-deser-array branch 2 times, most recently from cc0534b to c2b43c3 Compare September 19, 2016 18:34
Array(Type, dims) is very hard (expensive) to dispatch
@vtjnash vtjnash force-pushed the jn/faster-deser-array branch from c2b43c3 to 636f1e4 Compare September 20, 2016 17:26
@tkelman tkelman added the potential benchmark Could make a good benchmark in BaseBenchmarks label Sep 20, 2016
@tkelman
Copy link
Contributor

tkelman commented Sep 20, 2016

do we have any deserialization benchmarks? @nanosoldier runbenchmarks(ALL, vs = ":master")

@ViralBShah
Copy link
Member

ViralBShah commented Sep 20, 2016

Cc @kpamnany @jeff-regier Perhaps we can adapt the use case from Celeste.jl as a standalone deserialize benchmark. Would really help catch future regressions.

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@vtjnash
Copy link
Member Author

vtjnash commented Sep 20, 2016

It looks like the parallel::remotecall perf test may lightly involve this

@vtjnash vtjnash merged commit aca3311 into master Sep 20, 2016
@vtjnash vtjnash deleted the jn/faster-deser-array branch September 20, 2016 20:57
@stevengj
Copy link
Member

See #18633 for a small benchmark.

@shashi
Copy link
Contributor

shashi commented Feb 27, 2017

@tkelman this is candidate for #20736 ?

@shashi
Copy link
Contributor

shashi commented Feb 27, 2017

@tkelman made that easy for you: #20825

shashi pushed a commit that referenced this pull request Feb 27, 2017
Array(Type, dims) is very hard (expensive) to dispatch

(cherry picked from commit 636f1e4)
tkelman added a commit that referenced this pull request Mar 1, 2017
@KristofferC KristofferC removed the potential benchmark Could make a good benchmark in BaseBenchmarks label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants