[release 0.5] hack in a fix to getting the right lambda for the incremental deserializer #18452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that #18449 does not trigger on 0.5. |
|
oh, I guess this also needs #18415 backported first too |
|
can you add a test? I saw this error on gadfly and mamba in #18546, will upload logs soon |
|
Old travis logs backed up to
and restarted. May need to merge this into tk/backports-0.5.0 before @vtjnash (or @yuyichao?) wakes up and can identify if there's already an appropriate test for this on master or if a new one needs to be written. We'll still need a test for release-0.5 but I won't block starting my next pkgeval run on it. |
|
Master needs the test too, so we'll do that in a new PR and backport whenever it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18449
(the real, non-buggy fix is in #18413 for v0.6-dev master)