Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Regression for BigFloat and BigInt due to #51362 #53641

Open
Zentrik opened this issue Mar 7, 2024 · 3 comments
Open

Performance Regression for BigFloat and BigInt due to #51362 #53641

Zentrik opened this issue Mar 7, 2024 · 3 comments
Labels
bignums BigInt and BigFloat performance Must go faster regression Regression in behavior compared to a previous version regression 1.11 Regression in the 1.11 release

Comments

@Zentrik
Copy link
Member

Zentrik commented Mar 7, 2024

There seem to have been quite a few regressions recently on the scalar BaseBenchmarks, the real regressions seem to be due to #51362. The regressions seem to indicate #51362 had a bigger performance impact than intended, at least from what I gather reading the comments to that pr.

Full regression list is here, I've listed a couple of the biggest ones below

Benchmark % Change
scalar.arithmetic.(mul, Complex{BigFloat}, Complex{UInt64}) 50.08
scalar.arithmetic.(mul, Complex{BigInt}, Complex{BigFloat}) 49.82
scalar.arithmetic.(mul, UInt64, Complex{BigFloat}) 49.76
scalar.arithmetic.(mul, Complex{BigFloat}, Complex{BigInt}) 49.61
scalar.arithmetic.(mul, Complex{BigFloat}, Complex{Int64}) 49.47
scalar.arithmetic.(mul, UInt64, BigFloat) 49.33
scalar.arithmetic.(mul, BigFloat, Complex{Int64}) 48.49
scalar.arithmetic.(sub, Complex{BigFloat}, Complex{BigInt}) 47.95
@Zentrik
Copy link
Member Author

Zentrik commented Mar 7, 2024

There also seem to be a few regressions on the union array benchmarks involving BigFloats and BigInts, see here.

@oscardssmith oscardssmith added performance Must go faster regression Regression in behavior compared to a previous version bignums BigInt and BigFloat labels Mar 7, 2024
@oscardssmith oscardssmith added this to the 1.11 milestone Mar 7, 2024
@nsajko
Copy link
Contributor

nsajko commented Mar 23, 2024

I guess this should get better once #53584 is fixed.

@KristofferC
Copy link
Member

Since the cause was a correctness fix I will drop the milestone here but ideally something like #53607 could come in and fix it.

@KristofferC KristofferC removed this from the 1.11 milestone May 2, 2024
@KristofferC KristofferC added the regression 1.11 Regression in the 1.11 release label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bignums BigInt and BigFloat performance Must go faster regression Regression in behavior compared to a previous version regression 1.11 Regression in the 1.11 release
Projects
None yet
Development

No branches or pull requests

4 participants