Performance Regression on array indexing BaseBenchmarks due to #52189

[Zentrik]

There have been quite a few regressions since the memory pr 909bcea (full list).
The biggest regressions seemed to occur between 7f18f76 and f5d189f (regressions between these two commits or see Nanosoldier Report).
Here's some of the worst regressions,

Benchmark	% Change
array.index.(sumeach, SubArray{Int32, 2, Matrix{Int32}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false})	1550.45%
array.index.(sumcartesian, SubArray{Int32, 2, Matrix{Int32}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false})	1547.05%
array.index.(sumcartesian, SubArray{Int32, 2, Matrix{Int32}, Tuple{Base.Slice{Base.OneTo{Int64}}, Base.Slice{Base.OneTo{Int64}}}, true})	1522.54%
array.index.(sumcartesian, Matrix{Int32})	1408.69%
array.index.(sumeach, BaseBenchmarks.ArrayBenchmarks.ArrayLSLS{Int32, 2})	1407.37%
array.index.(sumcartesian, BaseBenchmarks.ArrayBenchmarks.ArrayLF{Int32, 2})	1404.21%
array.index.(sumeach, BaseBenchmarks.ArrayBenchmarks.ArrayLS{Int32, 2})	1403.94%
array.index.(sumcartesian, BaseBenchmarks.ArrayBenchmarks.ArrayLS{Int32, 2})	1398.14%
array.index.(sumcartesian, SubArray{Int32, 2, BaseBenchmarks.ArrayBenchmarks.ArrayLS{Int32, 2}, Tuple{Base.Slice{Base.OneTo{Int64}}, Base.Slice{Base.OneTo{Int64}}}, false})	1397.78%
array.index.(sumcartesian, BaseBenchmarks.ArrayBenchmarks.ArrayLSLS{Int32, 2})	1397.29%
array.index.(sumcartesian, Matrix{Int64})	684.16%

At least for the biggest two regressions, I bisected to #52189

[jishnub]

Xref #53158

[timholy]

Since I haven't seen a lot of discussion of this (quite serious) regression, let me at least point out a possible correlate (from JET):

OptimizationFailureReport(failed to optimize due to recursion: Base.wrap(::Type{Array}, ::MemoryRef{UInt8}, ::Int64))

nightly doesn't even have wrap. Is there a backport we should consider?

[KristofferC]

nightly doesn't even have wrap. Is there a backport we should consider?

#54927