Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document aliasing in map! #50814

Open
jlapeyre opened this issue Aug 7, 2023 · 2 comments
Open

Document aliasing in map! #50814

jlapeyre opened this issue Aug 7, 2023 · 2 comments
Labels
docs This change adds or pertains to documentation

Comments

@jlapeyre
Copy link
Contributor

jlapeyre commented Aug 7, 2023 •
edited
Loading

map! should either support aliasing or not and the choice should be documented and tested. (It could be documented that it's undefined, but probably a bad idea)

It may be better tested after the PR below merged, but the doc string should be updated.

Maybe auditing a bit for other similar functions that lack this kind of documentation would be a good idea. I'll add them here if I find them.

See

https://discourse.julialang.org/t/did-julia-community-do-something-to-improve-its-correctness/102515/86
@brenhinkeller brenhinkeller added the docs This change adds or pertains to documentation label Aug 7, 2023
@barucden
Copy link
Contributor

barucden commented Aug 7, 2023

Related to #39385

@jlapeyre
Copy link
Contributor Author

jlapeyre commented Aug 7, 2023 •
edited
Loading

Related to #39385

I came back to add that to the original comment, but you beat me to it. In particular this: #39385 (comment)

@gdalle gdalle mentioned this issue Aug 7, 2023
Merged
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlapeyre @brenhinkeller @barucden