Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in vcat performance #46121

Closed
kpamnany opened this issue Jul 21, 2022 · 2 comments
Closed

Regression in vcat performance #46121

kpamnany opened this issue Jul 21, 2022 · 2 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version

Comments

@kpamnany
Copy link
Contributor

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.7.1 (2021-12-22)
 _/ |\__'_|_|_|\__'_|  |
|__/                   |

julia> using BenchmarkTools

julia> begin
           a = Any[rand(Int) for _ in 1:10]
           num = 5
           @btime vcat($a, $num);
       end;
  43.047 ns (1 allocation: 144 bytes)
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.8.0-rc3 (2022-07-13)
 _/ |\__'_|_|_|\__'_|  |
|__/                   |

julia> using BenchmarkTools

julia> begin
           a = Any[rand(Int) for _ in 1:10]
           num = 5
           @btime vcat($a, $num);
       end;
  1.067 μs (14 allocations: 464 bytes)
@kpamnany kpamnany added performance Must go faster regression Regression in behavior compared to a previous version and removed performance Must go faster labels Jul 21, 2022
@ViralBShah ViralBShah added the performance Must go faster label Jul 21, 2022
@gbaraldi
Copy link
Member

This is fast again on master for reference.

@kpamnany
Copy link
Contributor Author

kpamnany commented Jul 21, 2022

This was fixed in #45028 which will be backported to 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

3 participants