Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

]add bad-name crashes Julia on master #43184

Closed
LilithHafner opened this issue Nov 22, 2021 · 12 comments
Closed

]add bad-name crashes Julia on master #43184

LilithHafner opened this issue Nov 22, 2021 · 12 comments

Comments

@LilithHafner
Copy link
Member 

x@X ~ % julia-1.8
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.8.0-DEV.1045 (2021-11-21)
 _/ |\__'_|_|_|\__'_|  |  Commit d87c3848c8 (0 days old master)
|__/                   |

julia> versioninfo()
Julia Version 1.8.0-DEV.1045
Commit d87c3848c8 (2021-11-21 15:31 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin19.6.0)
  CPU: Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake)

(@v1.8) pkg> add bad-name
ERROR: Unhandled Task ERROR: UndefVarError: bt not defined
Stacktrace:
 [1] display_error(io::Base.TTY, exception::ErrorException, backtrace::Vector{Ptr{Nothing}})
   @ Base ./client.jl:111
 [2] do_cmd(repl::REPL.LineEditREPL, input::String; do_rethrow::Bool)
   @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:392
 [3] do_cmd
   @ /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:377 [inlined]
 [4] (::Pkg.REPLMode.var"#24#27"{REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
   @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:550
 [5] #invokelatest#2
   @ ./essentials.jl:731 [inlined]
 [6] invokelatest
   @ ./essentials.jl:729 [inlined]
 [7] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
   @ REPL.LineEdit /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/LineEdit.jl:2509
 [8] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
   @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:1249
 [9] (::REPL.var"#49#54"{REPL.LineEditREPL, REPL.REPLBackendRef})()
   @ REPL ./task.jl:466

caused by: Unable to parse `bad-name` as a package.
Stacktrace:
  [1] pkgerror(msg::String)
    @ Pkg.Types /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/Types.jl:67
  [2] parse_package_identifier(word::String; add_or_develop::Bool)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:146
  [3] parse_package_args(args::Vector{Union{String, Pkg.REPLMode.Rev, Pkg.REPLMode.Subdir, Pkg.REPLMode.VersionToken}}; add_or_dev::Bool)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:100
  [4] parse_package(args::Vector{Pkg.REPLMode.QString}, options::Dict{Symbol, Any}; add_or_dev::Bool)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:11
  [5] (::Pkg.REPLMode.var"#66#71")(x::Vector{Pkg.REPLMode.QString}, y::Dict{Symbol, Any})
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/command_declarations.jl:99
  [6] Pkg.REPLMode.Command(statement::Pkg.REPLMode.Statement)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:366
  [7] iterate
    @ ./generator.jl:47 [inlined]
  [8] _collect(c::Vector{Pkg.REPLMode.Statement}, itr::Base.Generator{Vector{Pkg.REPLMode.Statement}, Type{Pkg.REPLMode.Command}}, #unused#::Base.EltypeUnknown, isz::Base.HasShape{1})
    @ Base ./array.jl:804
  [9] collect_similar
    @ ./array.jl:713 [inlined]
 [10] map
    @ ./abstractarray.jl:2859 [inlined]
 [11] do_cmd(repl::REPL.LineEditREPL, input::String; do_rethrow::Bool)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:383
 [12] do_cmd
    @ /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:377 [inlined]
 [13] (::Pkg.REPLMode.var"#24#27"{REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
    @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:550
 [14] #invokelatest#2
    @ ./essentials.jl:731 [inlined]
 [15] invokelatest
    @ ./essentials.jl:729 [inlined]
 [16] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
    @ REPL.LineEdit /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/LineEdit.jl:2509
 [17] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
    @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:1249
 [18] (::REPL.var"#49#54"{REPL.LineEditREPL, REPL.REPLBackendRef})()
    @ REPL ./task.jl:466
ERROR: TaskFailedException
Stacktrace:
  [1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
    @ Base ./task.jl:820
  [2] wait()
    @ Base ./task.jl:880
  [3] wait(c::Base.GenericCondition{ReentrantLock})
    @ Base ./condition.jl:124
  [4] take_buffered(c::Channel{Any})
    @ Base ./channels.jl:415
  [5] take!
    @ ./channels.jl:409 [inlined]
  [6] repl_backend_loop(backend::REPL.REPLBackend)
    @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:240
  [7] start_repl_backend(backend::REPL.REPLBackend, consumer::Any)
    @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:230
  [8] run_repl(repl::REPL.AbstractREPL, consumer::Any; backend_on_current_task::Bool)
    @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:367
  [9] run_repl(repl::REPL.AbstractREPL, consumer::Any)
    @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:354
 [10] (::Base.var"#933#935"{Bool, Bool, Bool})(REPL::Module)
    @ Base ./client.jl:403
 [11] #invokelatest#2
    @ ./essentials.jl:731 [inlined]
 [12] invokelatest
    @ ./essentials.jl:729 [inlined]
 [13] run_main_repl(interactive::Bool, quiet::Bool, banner::Bool, history_file::Bool, color_set::Bool)
    @ Base ./client.jl:388
 [14] exec_options(opts::Base.JLOptions)
    @ Base ./client.jl:318
 [15] _start()
    @ Base ./client.jl:506

    nested task error: UndefVarError: bt not defined
    Stacktrace:
     [1] display_error(io::Base.TTY, exception::ErrorException, backtrace::Vector{Ptr{Nothing}})
       @ Base ./client.jl:111
     [2] do_cmd(repl::REPL.LineEditREPL, input::String; do_rethrow::Bool)
       @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:392
     [3] do_cmd
       @ /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:377 [inlined]
     [4] (::Pkg.REPLMode.var"#24#27"{REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
       @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:550
     [5] #invokelatest#2
       @ ./essentials.jl:731 [inlined]
     [6] invokelatest
       @ ./essentials.jl:729 [inlined]
     [7] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
       @ REPL.LineEdit /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/LineEdit.jl:2509
     [8] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
       @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:1249
     [9] (::REPL.var"#49#54"{REPL.LineEditREPL, REPL.REPLBackendRef})()
       @ REPL ./task.jl:466
    
    caused by: Unable to parse `bad-name` as a package.
    Stacktrace:
      [1] pkgerror(msg::String)
        @ Pkg.Types /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/Types.jl:67
      [2] parse_package_identifier(word::String; add_or_develop::Bool)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:146
      [3] parse_package_args(args::Vector{Union{String, Pkg.REPLMode.Rev, Pkg.REPLMode.Subdir, Pkg.REPLMode.VersionToken}}; add_or_dev::Bool)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:100
      [4] parse_package(args::Vector{Pkg.REPLMode.QString}, options::Dict{Symbol, Any}; add_or_dev::Bool)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/argument_parsers.jl:11
      [5] (::Pkg.REPLMode.var"#66#71")(x::Vector{Pkg.REPLMode.QString}, y::Dict{Symbol, Any})
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/command_declarations.jl:99
      [6] Pkg.REPLMode.Command(statement::Pkg.REPLMode.Statement)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:366
      [7] iterate
        @ ./generator.jl:47 [inlined]
      [8] _collect(c::Vector{Pkg.REPLMode.Statement}, itr::Base.Generator{Vector{Pkg.REPLMode.Statement}, Type{Pkg.REPLMode.Command}}, #unused#::Base.EltypeUnknown, isz::Base.HasShape{1})
        @ Base ./array.jl:804
      [9] collect_similar
        @ ./array.jl:713 [inlined]
     [10] map
        @ ./abstractarray.jl:2859 [inlined]
     [11] do_cmd(repl::REPL.LineEditREPL, input::String; do_rethrow::Bool)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:383
     [12] do_cmd
        @ /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:377 [inlined]
     [13] (::Pkg.REPLMode.var"#24#27"{REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
        @ Pkg.REPLMode /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/Pkg/src/REPLMode/REPLMode.jl:550
     [14] #invokelatest#2
        @ ./essentials.jl:731 [inlined]
     [15] invokelatest
        @ ./essentials.jl:729 [inlined]
     [16] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
        @ REPL.LineEdit /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/LineEdit.jl:2509
     [17] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
        @ REPL /Applications/Julia-1.8.app/Contents/Resources/julia/share/julia/stdlib/v1.8/REPL/src/REPL.jl:1249
     [18] (::REPL.var"#49#54"{REPL.LineEditREPL, REPL.REPLBackendRef})()
        @ REPL ./task.jl:466
x@X ~ %
@Keno
Copy link
Member

Keno commented Nov 22, 2021

Fixed by #43173 (merged a few minutes ago, try updating).

@Keno Keno closed this as completed Nov 22, 2021
@LilithHafner
Copy link
Member Author

Wow! Speedy! Will https://julialang.org/downloads/nightlies/ already have the fix?

@DilumAluthge
Copy link
Member

DilumAluthge commented Nov 22, 2021 •
edited
Loading

It will be a little while (at least a few hours) before https://julialang.org/downloads/nightlies/ has the fix.

If you need the fix immediately, you'll need to build from source.

@LilithHafner
Copy link
Member Author

Thanks! I'm certainly happy to wait a few hours.

@Keno
Copy link
Member

Keno commented Nov 22, 2021

If you look in the macos CI job (look on the commit list on master, hit the CI status icon, find https://build.julialang.org/#/builders/63/builds/6505), you can see that the build finished and the binary is at: s3://julialangnightlies/assert_pretesting/mac/x64/1.8/julia-b078d77b74-mac64.dmg. However it hasn't been promoted to nightly yet, which doesn't happen until the tests finish.

@LilithHafner
Copy link
Member Author

Neat, thanks! I found that address at the end of the "Upload to AWS" section of buildbot, but I can't figure out how to download that file.

@Keno
Copy link
Member

Keno commented Nov 22, 2021

via http as https://julialangnightlies-s3.julialang.org/assert_pretesting/mac/x64/1.8/julia-b078d77b74-mac64.dmg or via s3 cli

@LilithHafner
Copy link
Member Author

Huzzah! Thanks so much!

x@X ~ % julia-1.8
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _' |  |
  | | |_| | | | (_| |  |  Version 1.8.0-DEV.1046 (2021-11-22)
 _/ |\__'_|_|_|\__'_|  |  Commit b078d77b74 (0 days old master)
|__/                   |

(@v1.8) pkg> add bad-name
ERROR: Unable to parse `bad-name` as a package.

(@v1.8) pkg>

How would I have figured out that the prefix changed from s3://julialangnightlies to https://julialangnightlies-s3.julialang.org?

@Keno
Copy link
Member

Keno commented Nov 22, 2021

How would I have figured out that the prefix changed from s3://julialangnightlies to https://julialangnightlies-s3.julialang.org?

I guess, you could have guess from the links on the nightlies page ;) or just used the s3 scli.

@LilithHafner
Copy link
Member Author

Ah! yes, I could have thought of the nightlies page as a reference. Thanks!

@KristofferC
Copy link
Member

Instead of going to the package builder, if you go to the testing builder, it has the full url.

@LilithHafner
Copy link
Member Author

Thanks!

@fredrikekre fredrikekre mentioned this issue Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KristofferC @Keno @DilumAluthge @LilithHafner