Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression with tuple tail recursion in v1.7 #41637

Closed
jfeist opened this issue Jul 19, 2021 · 3 comments
Closed

Performance regression with tuple tail recursion in v1.7 #41637

jfeist opened this issue Jul 19, 2021 · 3 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version

Comments

@jfeist
Copy link

jfeist commented Jul 19, 2021

I noticed a quite significant performance regression in tuple tail recursion from julia 1.6 to 1.7. Version 1.6 already had a regression for a specific case compared to 1.5, but in 1.7 it's even worse, and shows up for all the cases I checked. Full details in this thread: https://discourse.julialang.org/t/strange-performance-characteristics-and-regression-with-tuple-recursion/64888/2

@KristofferC KristofferC added performance Must go faster regression Regression in behavior compared to a previous version labels Jul 19, 2021
@KristofferC
Copy link
Member

Running a git bisect might be a good way to find the place where it regressed.

@simeonschaub
Copy link
Member

Ref #40814. I suspect c2ec70c is the culprit here as well.

@vtjnash
Copy link
Member

vtjnash commented Aug 24, 2023

Seems to be an LLVM optimization prediction heuristic that we cannot really guarantee. But seems to do well at M=2 again

M = 1:   2.729 ns (0 allocations: 0 bytes)
M = 2:   68.319 ns (0 allocations: 0 bytes)
M = 3:   7.410 μs (0 allocations: 0 bytes)
M = 4:   173.518 μs (0 allocations: 0 bytes)

@vtjnash vtjnash closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

4 participants