Set DelimitedFiles.readdlm use_mmap default to false for all OSes #40415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased resilience to edge cases where OS is reported Unix-like but Filesystem is abnormal
vtjnash
approved these changes
Apr 9, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…liaLang#40415) Increased resilience to edge cases where OS is reported Unix-like but Filesystem is abnormal Fixes JuliaLang#8891 Fixes JuliaLang#40352
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…liaLang#40415) Increased resilience to edge cases where OS is reported Unix-like but Filesystem is abnormal Fixes JuliaLang#8891 Fixes JuliaLang#40352
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…liaLang#40415) Increased resilience to edge cases where OS is reported Unix-like but Filesystem is abnormal Fixes JuliaLang#8891 Fixes JuliaLang#40352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased resilience to edge cases where
Sys.isunix() == truebut the Filesystem behaves Windows-like instead of Unix-like.Current behavior in these edge cases can cause ugly bugs, and I believe it is best to sacrifice default performance in favor of default portability.
@vtjnash has also demonstrated that the current default also leads to worse performance on Unix-like systems for very small delimited files, so the change in defaults also leads to improved performance in at least some situations.
Specific examples of edge cases where the current default is dangerous: