Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added canonicalize for Periods #37391

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Conversation

cfitz25
Copy link
Contributor

@cfitz25 cfitz25 commented Sep 4, 2020

When i was using canonicalize i had crashes sometimes when doing Period addition as sometimes a Period would be returned instead of a CompoundPeriod, this is a fix for that

@stevengj
Copy link
Member

stevengj commented Sep 4, 2020

Could use a test…

@cfitz25
Copy link
Contributor Author

cfitz25 commented Sep 4, 2020

Oops, sorry ill go create one now, thanks for the heads up

@stevengj stevengj added the dates Dates, times, and the Dates stdlib module label Sep 5, 2020
@stevengj
Copy link
Member

stevengj commented Sep 5, 2020

Maybe a NEWS item as well since this is a new method?

@cfitz25
Copy link
Contributor Author

cfitz25 commented Sep 5, 2020

Sorry i am new here, how would i make a NEWS item?

@stevengj
Copy link
Member

stevengj commented Sep 5, 2020

edit NEWS.md

@quinnj quinnj merged commit be1f3ab into JuliaLang:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dates Dates, times, and the Dates stdlib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants