-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back contains(haystack, needle) #35031
Comments
Yes, I miss this a lot. IIRC, the reason we settled on |
Ok I will make the PR to add Since it will follow that pattern |
Right now we have:
startswith(haystack, needle)
endswith(haystack, needle)
occursin(needle, haystack)
While
occursin(needle, haystack)
is right from the perspective of readingf(a, b)
asa f b
i.e.
needle occursin haystack
It is not consistent with
startwith
orendswith
.Back in julia 0.6 (IIRC) we had
contains(haystack, needle)
which still reads right:
haystack contains needle
.I would like to suggest we bring it back so that we can have that consistency.
This is part of a series of issues relating to invenia/Wrangling.jl#3
Will link others below for cross referencing.
#35032
#35033
The text was updated successfully, but these errors were encountered: