-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't assume Int
in _sametype
in broadcasting
#33391
Comments
Wasn't this put into 1.0.3? |
Ah, I only checked 1.0.2 and 1.0.5 |
I realised the issue is with the call to However, I think the hard coding of _sametype(a::OneTo{T}, b::OneTo{V}) where {T,V} = OneTo{promote_type(T,V)}(a) |
We default to julia> to_indices(rand(2), (0x01,))
(1,) |
OK, fair enough. In any case that code has been removed and I've fixed the issue in InfiniteArrays.jl. So I'll close this. |
These lines are breaking InfiniteArrays.jl in Julia v1.0.5 (but not other v1.x or v1.0.x):
julia/base/broadcast.jl
Line 448 in 3af96bc
It seems like a bad idea to assume
Int
, as they may beBigInt
. I can work around it but this should have been considered a breaking change.The text was updated successfully, but these errors were encountered: