Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two problems with LU for rectangular matrices #3309

Closed
bsxfan opened this issue Jun 6, 2013 · 3 comments
Closed

two problems with LU for rectangular matrices #3309

bsxfan opened this issue Jun 6, 2013 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@bsxfan
Copy link

bsxfan commented Jun 6, 2013

One of these problems has already been reported in the still open issue #2371, although the behaviour reported there was somewhat different from what I see now.

As far as I can see, F = lufact(randn(2,3)) is successful---it stores the L and U factors together in a 2 x 3 matrix. But there seems to be a little bit of finger trouble with extracting L:

julia> F[:L]
 ERROR: argument dimensions must match
  in promote_shape at operators.jl:157
  in + at array.jl:935
  in getindex at linalg/factorization.jl:151  

For this case, F[:U] and F[:P] work. But for F=lufact(randn(3,2)), F[:P] also fails.

det(LU) fails to check that the matrix is square. It should behave the same as det(randn(2,3)), which crashes as it should with ERROR: DimensionMismatch("det only defined for square matrices").

@ViralBShah
Copy link
Member

Cc: @andreasnoackjensen

@andreasnoack
Copy link
Member

I have fixed the LU issues in #3315

@ViralBShah
Copy link
Member

This is already fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants