faster rand(::Tuple) #32208
Merged
faster rand(::Tuple) #32208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
performance
This was an oversight. This makes rand(::MersenneTwister, ::Tuple) generally faster.
rfourquet
force-pushed
the
rf/rand/tuple-pow2
branch
from
d02b695
to
59b56ce
Compare
|
According to recent documentation, it's fine to change generated streams of random numbers for a given seed. Removing |
rfourquet
removed
the
minor change
StefanKarpinski
added
the
minor change
|
No, this is precisely what the "minor change" label is for: changes that are allowed in minor releases but not in patch releases. We do not promise random stream stability but we will not change the behavior of programs in point releases except to fix bugs. |
|
I've added the "needs news" label because minor changes should always be mentioned in NEWS. |
rfourquet
added a commit
that referenced
this pull request
Sep 27, 2019
|
Oops, sorry, I misunderstood! News added at #33404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is quite simple:
L, we do like for length 4, i.e. use a mask:rand(UInt32) & (L-1)rand(Base.OneTo(n))(used inrand(::Tuple)) slower thanrand(1:n)forMersenneTwister.This breaks the reproducibility of generated streams, but we now have a precedent for that.