Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the extra 7zip compression and just use nsis directly for compression #31875

Closed
musm opened this issue Apr 29, 2019 · 1 comment · Fixed by #31879
Closed

Remove the extra 7zip compression and just use nsis directly for compression #31875

musm opened this issue Apr 29, 2019 · 1 comment · Fixed by #31879

Comments

@musm
Copy link
Contributor

musm commented Apr 29, 2019 •
edited
Loading

Upgrading to the latest nsis installer and setting the compression to lzma in the config for the nsis installer I am able to produce a windows installer that is the same size as that achieved by the additional compression step through the post-processing 7z stage in the makefile.

In other words the stages for https://github.com/JuliaLang/julia/blob/master/Makefile#L467 are not needed.

What this means is that decompression occurs during the installation time.

Should I make a PR for this change?
@musm
Copy link
Contributor Author

musm commented Apr 29, 2019 •
edited
Loading

This also means we can delete a whole bunch that extra junk required for the 7z stage and thus also resolve #30475

@musm musm mentioned this issue Apr 29, 2019
Merged
@musm musm mentioned this issue Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade and use NSIS for compression instead of extra 7z stage musm/julia
1 participant
@musm