Allow passing a function to extrema #30323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
force-pushed
the
aa/extrema-function
branch
from
3e09b6b
to
3088c9b
Compare
StefanKarpinski
approved these changes
Dec 10, 2018
StefanKarpinski
added
backport pending 1.1
triage
|
Marking for triage just to discuss whether we're allowing backports of new features past the 1.1 release branch date. |
ararslan
commented
Dec 10, 2018
ararslan
force-pushed
the
aa/extrema-function
branch
from
3088c9b
to
a9356b6
Compare
|
Test failures are from Pkg due to the current registry apocalypse |
|
Should be better now. |
|
No, I don't think we should backport new features. IMO backporting after branch is only to fix release blockers. |
ararslan
force-pushed
the
aa/extrema-function
branch
from
a9356b6
to
7fb1b46
Compare
Currently `minimum` and `maximum` can accept a function argument, but `extrema` cannot. This makes it consistent.
ararslan
force-pushed
the
aa/extrema-function
branch
from
7fb1b46
to
3e2b0a5
Compare
|
32-bit Windows failure is the Profile thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
minimumandmaximumcan accept a function argument, butextremacannot. This makes it consistent.I've set theSet to 1.2.!!! compatto Julia 1.1, but if this can't make it into the release then I can set it to 1.2 or whatever.