Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlining dependent on @nospecialize? #29147

Closed
KristofferC opened this issue Sep 12, 2018 · 1 comment
Closed

Inlining dependent on @nospecialize? #29147

KristofferC opened this issue Sep 12, 2018 · 1 comment
Labels
compiler:inference Type inference performance Must go faster

Comments

@KristofferC
Copy link
Member

In #29133 it was noted that a @nospecialize annotation on iterate for tuples lead to a performance regression in the following (badly named becuase it isn't really testing the perf of setindex! at all) benchmark:

perf_setindex!(A, val, inds) = setindex!(A, val, inds...)

using BenchmarkTools
s = 2
A = rand(Float64, ntuple(one, s)...)
y = one(eltype(A))
i = length(A)
@btime perf_setindex!($(fill!(A, y)), $y, $i)

According to @vtjnash:

This is strange—inference isn’t supposed to look at this flag. It would be helpful to understand what inlining decisions got made and why, as this might be indicating a deeper problem.

Opening this to track.

@vtjnash
Copy link
Member

vtjnash commented Oct 15, 2018

dup #29114

@vtjnash vtjnash closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference performance Must go faster
Projects
None yet
Development

No branches or pull requests

2 participants