Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logabsdet fails for singular matrices #550

Closed
garrison opened this issue Aug 12, 2018 · 0 comments · Fixed by JuliaLang/julia#28620
Closed

logabsdet fails for singular matrices #550

garrison opened this issue Aug 12, 2018 · 0 comments · Fixed by JuliaLang/julia#28620
Labels
bug Something isn't working regression Regression in behavior compared to a previous version

Comments

@garrison
Copy link
Member

logabsdet fails for singular matrices on julia 0.7 and 1.0. This is a regression from julia 0.6.

julia> logabsdet([1 2; 1 2])
ERROR: SingularException(2)

This seems pretty clearly unintentional, since this case is explicitly handled in the code; this line is just not reached through this call path. The current behavior also contracts the docstring, which says

Equivalent to (log(abs(det(M))), sign(det(M))), but may provide increased accuracy and/or speed.

Pull request coming soon.
@garrison garrison added bug Something isn't working regression Regression in behavior compared to a previous version linear algebra labels Aug 12, 2018
garrison referenced this issue in JuliaLang/julia Aug 12, 2018
@garrison
Fix #28619, logabsdet for singular matrices
6b21451
@garrison garrison mentioned this issue Aug 13, 2018
Merged
andreasnoack referenced this issue in JuliaLang/julia Aug 13, 2018
@garrison @andreasnoack
Fix #28619, logabsdet for singular matrices (#28620)
0846eb5
KristofferC referenced this issue in JuliaLang/julia Aug 19, 2018
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
bc95c30 
(cherry picked from commit 0846eb5)
KristofferC referenced this issue in JuliaLang/julia Aug 19, 2018
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
171718d 
(cherry picked from commit 0846eb5)
@KristofferC KristofferC mentioned this issue Aug 19, 2018
Merged
KristofferC referenced this issue in JuliaLang/julia Aug 19, 2018
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
8deb99b 
(cherry picked from commit 0846eb5)
KristofferC referenced this issue in JuliaLang/julia Sep 8, 2018
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
05be83d 
(cherry picked from commit 0846eb5)
KristofferC referenced this issue in JuliaLang/julia Sep 8, 2018
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
3ba7d66 
(cherry picked from commit 0846eb5)
KristofferC referenced this issue in JuliaLang/julia Feb 11, 2019
@garrison @KristofferC
Fix #28619, logabsdet for singular matrices (#28620)
82fa483 
(cherry picked from commit 0846eb5)
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #28619, logabsdet for singular matrices JuliaLang/julia
1 participant
@garrison