Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@which pointing to buildbot directory on nightly builds #28052

Closed
tkoolen opened this issue Jul 11, 2018 · 12 comments
Closed

@which pointing to buildbot directory on nightly builds #28052

tkoolen opened this issue Jul 11, 2018 · 12 comments
Labels
error handling Handling of exceptions by Julia or the user

Comments

@tkoolen
Copy link
Contributor

tkoolen commented Jul 11, 2018

julia> using LinearAlgebra

julia> @which Matrix(Diagonal(rand(3)))
(::Type{Array{T,2} where T})(D::Diagonal) in LinearAlgebra at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/LinearAlgebra/src/diagonal.jl:56

julia> versioninfo()
Julia Version 0.7.0-beta.201
Commit cdd4e84ac9 (2018-07-07 22:13 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i7-3820QM CPU @ 2.70GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, ivybridge)
@KristofferC
Copy link
Member

KristofferC commented Jul 11, 2018

I think that has always been the case?

@fredrikekre
Copy link
Member

I think that has always been the case?

But when stdlib was in the base/ directory the path was printed relative that, so it never leaked out.

@KristofferC
Copy link
Member

Ah, good point.

@fredrikekre
Copy link
Member

Perhaps those paths should be printed relative the julia root directory instead? IMO

julia> @which println("Hello")
println(xs...) in Base at base/coreio.jl:4

is better than the current

julia> @which println("Hello")
println(xs...) in Base at coreio.jl:4

and files in stdlib files would then print like stdlib/LinearAlgebra/...

@tkoolen
Copy link
Contributor Author

tkoolen commented Jul 11, 2018

Note by the way that this also applies to @edit, which makes it harder to see how things are implemented in stdlib packages on nightly.

@hessammehr
Copy link
Contributor

hessammehr commented Aug 8, 2018

Getting the same behaviour now on 0.7.0. :(

Seconding @tkoolen's point: it's a shame because you lose the easy path to debugging/contributing to Julia using @edit .

@carstenbauer
Copy link
Member

Just ran into this issue on stable Julia 1.0. Note that the links generated when executing @which in a jupyter notebook won't work because of this. Hope this will be fixed soon!

@tpapp
Copy link
Contributor

tpapp commented Sep 8, 2018

@crstnbr: note that compiling from source is a very simple workaround in the meantime.

@carstenbauer
Copy link
Member

Because of this Rebugger can't jump into stdlib code.


@crstnbr: note that compiling from source is a very simple workaround in the meantime.

It's not very simple on Windows but thanks for the comment.

@ihnorton ihnorton added the error handling Handling of exceptions by Julia or the user label Oct 2, 2018
@RalphAS
Copy link

RalphAS commented Oct 13, 2018

dup of #26314. Workaround is to build one's own system image. (Easier now that PkgCompiler works.)

@cossio
Copy link
Contributor

cossio commented Oct 18, 2018

@editstill does not work for stdlib functions because of this, Julia v1.0.1.

@vtjnash
Copy link
Member

vtjnash commented Oct 26, 2018

as mentioned above, this is a duplicate

@vtjnash vtjnash closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error handling Handling of exceptions by Julia or the user
Projects
None yet
Development

No branches or pull requests

10 participants