move Pkg to stdlib #25705

KristofferC · 2018-01-23T15:23:12Z

Pkg3 will replace Pkg(2) but moving it to the stdlib first will make that transition easier.

On the few places Pkg is used in base, I temporarily just used a Ref that Pkg fills.

vchuravy · 2018-01-23T15:43:38Z

base/interactiveutil.jl

        print(io, "  Package Status:")
-        if isdir(Pkg.dir())
+        if isdir(PKG_MODULE_REF[].dir())


I think you might need to use invokelatest here. @vtjnash should be able to confirm that.

Seems to work ok actually.

vchuravy · 2018-01-23T15:44:59Z

stdlib/Pkg/src/Pkg.jl

-export Dir, Types, Reqs, Cache, Read, Query, Resolve, Write, Entry
-export dir, init, rm, add, available, installed, status, clone, checkout,
-       update, resolve, test, build, free, pin, PkgError, setprotocol!
+#export Dir, Types, Reqs, Cache, Read, Query, Resolve, Write, Entry


These should probably be kept exported?

JeffBezanson · 2018-01-26T00:24:29Z

Looks like freebsd is still trying to run pkg tests?

KristofferC · 2018-01-26T07:07:57Z

Yeah, perhaps that can be removed @iblis17

Does anyone know the reason for splitting the tests into two parts for CI? Something with online / offline tests but choosetests already checks Internet connectivity and filters based on that.

iblislin · 2018-01-27T05:28:03Z

.travis.yml

@@ -144,7 +144,7 @@ script:
    - /tmp/julia/bin/julia -e 'versioninfo()'
    - pushd /tmp/julia/share/julia/test
    - /tmp/julia/bin/julia --check-bounds=yes runtests.jl $TESTSTORUN &&
-      /tmp/julia/bin/julia --check-bounds=yes runtests.jl libgit2-online download pkg
+      /tmp/julia/bin/julia --check-bounds=yes runtests.jl libgit2-online download


.circleci/config.yml need to be changed as well?

Yes, I didn't know that existed, thanks.

iblislin · 2018-01-27T05:31:43Z

I think I should provde cumstom shell script like Travis and CircleCI does in long-term...
(Let me figure out how to make it

See also: - JuliaLang#25705 (comment) - JuliaLang#25705 (comment)

See also: - JuliaLang#25705 (comment) - JuliaLang#25705 (comment) [av skip]

See also: - #25705 (comment) - #25705 (comment) [av skip]

KristofferC · 2018-01-29T15:52:27Z

All CI now fail with

julia: /home/travis/build/JuliaLang/julia/src/codegen.cpp:1096:
jl_llvm_functions_t jl_compile_linfo(jl_method_instance_t**, jl_code_info_t*, size_t, const jl_cgparams_t*):
Assertion `li->min_world <= world && li->max_world >= world' failed.

during precompile. Perhaps adding some debug printing to precompile.jl would be useful?

StefanKarpinski · 2018-01-29T16:30:43Z

cc @vtjnash ^

vchuravy · 2018-01-29T23:30:40Z

I would suspect that the worldage error is: #25705 (comment)

iblislin · 2018-01-30T02:05:00Z

.freebsdci.sh

+
+    gmake testall \
+        test-download \
+        test-Pkg \ # <- TODO: Should only test Pkg/pkg but no rule for test-Pkg/pkg


The comment in this line neutralized the effect of \ , so FreeBSD CI build failed.

line 73:
https://freebsdci.julialang.org/#/builders/1/builds/7031/steps/7/logs/stdio

Oops, thanks.

Is there anyway we could run this as julia test/runtests.jl test-Pkg/pkg?

I think invoking ./usr/bin/julia should work

KristofferC · 2018-01-30T09:01:35Z

@vchuravy But the PKG_MODULE_REF thing doesn't exist at all anymore on the newer commits because enough stuff got moved to stdlib that it wasn't needed anymore.

See also: - #25705 (comment) - #25705 (comment) [av skip]

iblislin · 2018-01-30T14:10:48Z

.freebsdci.sh

-        test-pkg \
-        test-libgit2-online
+    ./usr/bin/julia test/runtests.jl all
+    ./usr/bin/julia test/runtests.jl libgit2-online Pkg/pkg download


need --check-bounds=yes?

Don't think so, already gets applied at https://github.com/JuliaLang/julia/blob/master/test/testenv.jl#L20

KristofferC · 2018-01-30T15:58:32Z

The world error assertion was disabled from consulting @vtjnash and he said it wasn't really a problem disabling it and that he would look at it later.

StefanKarpinski · 2018-01-30T16:05:57Z

fix #25705 (comment)

Ref #25705 (cherry picked from commit 3dd40ff)

Details on the versions checks being used: JuliaLang/julia#25705 (544a5b8e39) => 0.7.0-DEV.3656 JuliaLang/julia#27095 (a209a45450) => 0.7.0-DEV.5183

KristofferC added the stdlib Julia's standard library label Jan 23, 2018

KristofferC mentioned this pull request Jan 23, 2018

Move LibGit2 to stdlib #25706

Merged

KristofferC added the packages Package management and loading label Jan 23, 2018

vchuravy reviewed Jan 23, 2018

View reviewed changes

KristofferC force-pushed the kc/excise_pkg branch 3 times, most recently from f394b70 to d547f37 Compare January 23, 2018 18:32

JeffBezanson added this to the 1.0 milestone Jan 23, 2018

vchuravy mentioned this pull request Jan 24, 2018

Bootstrap Pkg3 and add it to stdlib #25714

Closed

1 task

KristofferC force-pushed the kc/excise_pkg branch 5 times, most recently from 28816ca to 35167fe Compare January 25, 2018 16:11

iblislin reviewed Jan 27, 2018

View reviewed changes

KristofferC force-pushed the kc/excise_pkg branch from 0733826 to a42736b Compare January 27, 2018 12:27

iblislin added a commit to iblislin/julia that referenced this pull request Jan 28, 2018

introduce customizable build scripts for FreeBSD CI

b19f3bf

See also: - JuliaLang#25705 (comment) - JuliaLang#25705 (comment)

iblislin added a commit to iblislin/julia that referenced this pull request Jan 28, 2018

introduce customizable build scripts for FreeBSD CI

dc3a0f0

See also: - JuliaLang#25705 (comment) - JuliaLang#25705 (comment) [av skip]

iblislin mentioned this pull request Jan 28, 2018

introduce customizable build scripts for FreeBSD CI #25787

Closed

KristofferC force-pushed the kc/excise_pkg branch from a42736b to 4154995 Compare January 29, 2018 11:00

KristofferC pushed a commit that referenced this pull request Jan 29, 2018

introduce customizable build scripts for FreeBSD CI

4163e50

See also: - #25705 (comment) - #25705 (comment) [av skip]

KristofferC force-pushed the kc/excise_pkg branch 3 times, most recently from 3cd4549 to 150bdf1 Compare January 29, 2018 13:29

iblislin reviewed Jan 30, 2018

View reviewed changes

iblislin added 2 commits January 30, 2018 11:33

introduce customizable build scripts for FreeBSD CI

894d149

See also: - #25705 (comment) - #25705 (comment) [av skip]

single script

3dd40ff

KristofferC force-pushed the kc/excise_pkg branch 2 times, most recently from 4873924 to 74c884f Compare January 30, 2018 12:18

KristofferC added 2 commits January 30, 2018 14:31

move Pkg to stdlib

ca65ee9

comment out world age assertion

45c55e8

KristofferC force-pushed the kc/excise_pkg branch from 74c884f to 45c55e8 Compare January 30, 2018 13:31

iblislin reviewed Jan 30, 2018

View reviewed changes

KristofferC merged commit 544a5b8 into master Jan 30, 2018

fredrikekre deleted the kc/excise_pkg branch January 30, 2018 15:58

vtjnash added a commit that referenced this pull request Feb 7, 2018

fix compilation world-age assertion

74a34d2

fix #25705 (comment)

vtjnash mentioned this pull request Feb 7, 2018

fix compilation world-age assertion #25933

Merged

vtjnash added a commit that referenced this pull request Feb 12, 2018

fix compilation world-age assertion

349600d

fix #25705 (comment)

vtjnash added a commit that referenced this pull request Feb 14, 2018

fix compilation world-age assertion (#25933)

a2e4f16

fix #25705 (comment)

ararslan pushed a commit that referenced this pull request May 2, 2018

Add customizable build scripts for FreeBSD CI

1b309c9

Ref #25705 (cherry picked from commit 3dd40ff)

ararslan pushed a commit that referenced this pull request May 8, 2018

Add customizable build scripts for FreeBSD CI

f75a501

Ref #25705 (cherry picked from commit 3dd40ff)

ararslan pushed a commit that referenced this pull request May 27, 2018

Add customizable build scripts for FreeBSD CI

4762397

Ref #25705 (cherry picked from commit 3dd40ff)

omus added a commit to JuliaTesting/Mocking.jl that referenced this pull request Jun 27, 2018

Code review suggestions

e2bd9fa

Details on the versions checks being used: JuliaLang/julia#25705 (544a5b8e39) => 0.7.0-DEV.3656 JuliaLang/julia#27095 (a209a45450) => 0.7.0-DEV.5183

KristofferC mentioned this pull request Aug 23, 2018

StackOverflowError when loading two modules #28813

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move Pkg to stdlib #25705

move Pkg to stdlib #25705

KristofferC commented Jan 23, 2018

vchuravy Jan 23, 2018

KristofferC Jan 24, 2018

vchuravy Jan 23, 2018

JeffBezanson commented Jan 26, 2018

KristofferC commented Jan 26, 2018 •

edited

Loading

iblislin Jan 27, 2018

KristofferC Jan 27, 2018

iblislin commented Jan 27, 2018

KristofferC commented Jan 29, 2018 •

edited

Loading

StefanKarpinski commented Jan 29, 2018

vchuravy commented Jan 29, 2018

iblislin Jan 30, 2018

KristofferC Jan 30, 2018

KristofferC Jan 30, 2018

iblislin Jan 30, 2018

KristofferC commented Jan 30, 2018

iblislin Jan 30, 2018

KristofferC Jan 30, 2018

iblislin Jan 30, 2018

KristofferC commented Jan 30, 2018

StefanKarpinski commented Jan 30, 2018

move Pkg to stdlib #25705

move Pkg to stdlib #25705

Conversation

KristofferC commented Jan 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeffBezanson commented Jan 26, 2018

KristofferC commented Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iblislin commented Jan 27, 2018

KristofferC commented Jan 29, 2018 • edited Loading

StefanKarpinski commented Jan 29, 2018

vchuravy commented Jan 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KristofferC commented Jan 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KristofferC commented Jan 30, 2018

StefanKarpinski commented Jan 30, 2018

KristofferC commented Jan 26, 2018 •

edited

Loading

KristofferC commented Jan 29, 2018 •

edited

Loading