-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7 on 64-bit Windows four times slower than 0.6.2 #25329
Comments
Spending some work trying to pinpoint this more than "things got slower" would be very helpful. |
It's probably compilation time. |
Whatever it is the hit is painful. There are around 400 tests, organized into groups. Each group is timed separately. The slowdown varies, for one group of tests the slowdown of 0.7 is TWENTY TIMES compared to 0.6.2.
versus
Is there any value in pursuing this further? What is the plan concerning compilation, if that is what it is? Thanks. |
|
Interesting: it appears to be somehow related to the operations on a sparse matrix. In particular, memory allocation went through the roof. Closer investigation then revealed that the sparse matrix was in fact not sparse, it was a two-dimensional array in 0.7.. So instead of |
Alright, that makes sense, I think compilation regressions like this would have been spotted earlier. So I guess the interesting thing now is to find the place that used to give a sparse matrix. |
It was |
Apparently this is not the whole story yet. A. Every single test set is now uniformly around 50% slower than for 0.6.2. |
The culprit of the remaining major slowdown is |
The operations that caused MAJOR slowdowns have been reported separately. What remains is the universal increase of runtime (compilation?) of around 50%. |
Should this stay open to track the overall slowdown? |
xref #25254 |
I believe #25254 is about load time regressions from 0.5.x to 0.6.x, which for now persist in 0.7 but should be no worse. |
Is FinEtools updated for v1.0 to see if this is still an issue? I think a lot of the early compile time regressions have been addressed so I'd be interested to see if it still exists for this package. |
Unfortunately at this point I don't have a version of the package that would run both with 0.6 and 1.0. However most of the tests are one-to-one, even when the number of tests changed. Overall I would say 1.0 runs the tests as fast as 0.6, with some exceptions: on one test set 1.0 is considerably faster, and on one test set 1.0 is about 20% slower. I might try to find out what precisely is slower. |
Doesn't seem like there is anything concrete to do here anymore. |
When I run tests for FinEtools I find that with the current 0.7 the tests take four times as long as with 0.6.2. I haven't tried to track down a particular source of the slowdown. First I wanted to find out if there was a known reason for this, something that perhaps was planned to be fixed soon.
The text was updated successfully, but these errors were encountered: