Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Base.Base64 with stdlib Base64 module #24361

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Conversation

JeffBezanson
Copy link
Member

Starting with #24285, I found a way to fully replace the current base64 code with @bicycle1885 's implementation in the stdlib, without moving anything else first.

@JeffBezanson JeffBezanson added excision Removal of code from Base or the repository stdlib Julia's standard library labels Oct 27, 2017
@bicycle1885
Copy link
Member

I cannot come up with this kind of solution! Thank you!

@JeffBezanson
Copy link
Member Author

AV passed; closed and reopened to trigger travis.

@StefanKarpinski
Copy link
Member

Can't you just sign into Travis and restart the build?

@JeffBezanson JeffBezanson merged commit a8f8df6 into master Oct 28, 2017
@JeffBezanson JeffBezanson deleted the bicycle1885-base64 branch October 28, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excision Removal of code from Base or the repository stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants