Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sys.isfreebsd() #22794

Closed
musm opened this issue Jul 13, 2017 · 6 comments
Closed

Add Sys.isfreebsd() #22794

musm opened this issue Jul 13, 2017 · 6 comments
Labels
filesystem Underlying file system and functions that use it speculative Whether the change will be implemented is speculative system:freebsd Affects only FreeBSD

Comments

@musm
Copy link
Contributor

musm commented Jul 13, 2017

Might be useful to add Sys.freebsd() now that it looks like there is more support for the platform.

@tkelman
Copy link
Contributor

tkelman commented Jul 13, 2017

Sys.isbsd exists

@musm
Copy link
Contributor Author

musm commented Jul 13, 2017

Doesn't that also include, e.g. macOS.
I'm not 100 convinced this is necessarily needed, but it might be useful instead of Sys.KERNEL === :FreeBSD

@ararslan ararslan changed the title Add Sys.freebsd() Add Sys.isfreebsd() Jul 13, 2017
@ararslan
Copy link
Member

I don't think it would hurt to add it but at the same time I'm not sure there are all that many situations where it's useful. In particular, it appears there's only one place in this repo where it would even be used, and that's in the terminal tests.

The only other FreeBSD conditional code I've seen in the wild is new in BinDeps (I added it) but that's internal. Code that uses BinDeps but still conditions on Sys.KERNEL to detect FreeBSD really doesn't need to do the conditional because of the os argument to provider. I believe HDF5.jl does this.

Given that no one regularly tests Julia on OpenBSD, DragonFly, et al. (and last I tried I couldn't get Julia to build on OpenBSD, DragonFly, and even 32-bit FreeBSD), Sys.isbsd() && !Sys.isapple() is effectively FreeBSD.

@ararslan ararslan added filesystem Underlying file system and functions that use it system:freebsd Affects only FreeBSD speculative Whether the change will be implemented is speculative labels Jul 13, 2017
@iblislin
Copy link
Member

(and last I tried I couldn't get Julia to build on OpenBSD, DragonFly, and even 32-bit FreeBSD)

(@ararslan There is a patch not upsteamed for i386 FreeBSD: https://github.com/lwhsu/freebsd-ports-lang-julia/blob/master/files/extra-patch-ui_Makefile)

@ararslan
Copy link
Member

Nice, it would be good to submit that as a PR.

@musm
Copy link
Contributor Author

musm commented Sep 19, 2017

perhaps not worth it, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem Underlying file system and functions that use it speculative Whether the change will be implemented is speculative system:freebsd Affects only FreeBSD
Projects
None yet
Development

No branches or pull requests

4 participants