Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding issues #21137

Closed
JeffBezanson opened this issue Mar 22, 2017 · 4 comments
Closed

embedding issues #21137

JeffBezanson opened this issue Mar 22, 2017 · 4 comments
Assignees
Labels
building Build system, or building Julia or its dependencies embedding Embedding Julia using the C API regression Regression in behavior compared to a previous version
Milestone

Comments

@JeffBezanson
Copy link
Member

Trying to run the embedding example I'm hitting a number of issues. Some I can fix myself (in an upcoming PR) but others I'll need help with:

  • Running make gives
/home/jeff/src/julia/Make.inc:120: *** cowardly refusing to build from source directory with a shell-metacharacter in the path (got: $(abspath ..)).  Stop.
  • The world age is 0, causing e.g. the jl_show call in embedding.c to fail. Adding jl_get_ptls_states()->world_age = jl_world_counter; to jl_init fixes it, but I wouldn't expect that to be necessary. Where should this initialization happen?

These I can fix unless there are objections:

  • Need to add JCPPFLAGS and JCFLAGS to examples/Makefile.
  • Default system image path when calling jl_init is broken.
@JeffBezanson JeffBezanson added the regression Regression in behavior compared to a previous version label Mar 22, 2017
@JeffBezanson JeffBezanson added this to the 0.6.0 milestone Mar 22, 2017
@ararslan ararslan added building Build system, or building Julia or its dependencies embedding Embedding Julia using the C API labels Mar 22, 2017
@ararslan
Copy link
Member

cc @tkelman and @staticfloat for point 1, @vtjnash for point 2

@vtjnash
Copy link
Member

vtjnash commented Mar 22, 2017

the jl_show call

...should be gotten rid of

we don't need yet another entry point now that we have jl_call and cfunction

@staticfloat
Copy link
Member

@JeffBezanson see #21140 for the incredibly in-depth and elaborate workaround required to fix part one.

@JeffBezanson JeffBezanson self-assigned this Apr 6, 2017
@JeffBezanson
Copy link
Member Author

Fixed by #21299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies embedding Embedding Julia using the C API regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

4 participants