Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace errno() with libuv version #1924

Closed
3 tasks
vtjnash opened this issue Jan 8, 2013 · 7 comments
Closed
3 tasks

replace errno() with libuv version #1924

vtjnash opened this issue Jan 8, 2013 · 7 comments
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior io Involving the I/O subsystem: libuv, read, write, etc.
Milestone

Comments

@vtjnash
Copy link
Member

vtjnash commented Jan 8, 2013

  • convert errno() -> uv_last_error()
  • convert E_codes -> libuv E_codes
  • make useful: uv_strerror() / uv_err_name()
@ghost ghost assigned Keno Feb 2, 2013
@Keno
Copy link
Member

Keno commented Feb 6, 2013

This is essentially done. I'll take another pass through this soon and make sure it's used everywhere, but other than that we should be good.

@ViralBShah
Copy link
Member

@loladiro Can you fix this today/tomorrow? If not, we should push to 0.2.

@Keno
Copy link
Member

Keno commented Feb 6, 2013

Yes, I'll to do it tomorrow.

@StefanKarpinski
Copy link
Member

bump: is this done? seems like we're very close...

@StefanKarpinski
Copy link
Member

I'm moving this to 0.2.

@JeffBezanson
Copy link
Member

I really hope this can be cleaned up. I see we now have:

UV_error_t, UVError, _uv_lastsystemerror, _uv_lasterror, struverror, uverrorname, uv_error, errno,
strerror, system_error, SystemError

Come on, this is starting to look like a PHP API.

@Keno
Copy link
Member

Keno commented Jun 14, 2013

We came to the conclusion that this is pretty much solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

No branches or pull requests

5 participants