stacktraces test failing with no-inline

[vtjnash]

Looks like #16335 introduced a failure in the stacktraces test with inlining disabled:

$ julia --inline=no runtests.jl stacktraces
     * stacktraces          Test Failed
  Expression: frame.inlined === inlined
   Evaluated: false is true
ERROR: LoadError: LoadError: There was an error during testing
 in error(::String) at ./error.jl:21
 in record(::Base.Test.FallbackTestSet, ::Base.Test.Fail) at ./test.jl:321
 in do_test(::Base.Test.Returned, ::Expr) at ./test.jl:219
 in macro expansion; at /Volumes/Lion/Users/jameson/Documents/julia/test/stacktraces.jl:97 [inlined]
 in anonymous at ./<missing>:?
 in include_from_node1(::String) at ./loading.jl:426
 in macro expansion at ./util.jl:179 [inlined]
 in runtests(::String) at /Volumes/Lion/Users/jameson/Documents/julia/test/testdefs.jl:7
 in (::##16#24)(::String) at /Volumes/Lion/Users/jameson/Documents/julia/test/runtests.jl:36
 in (::Base.##277#278{##16#24,Tuple{String},Array{Any,1}})() at ./multi.jl:781
 in run_work_thunk(::Base.##277#278{##16#24,Tuple{String},Array{Any,1}}, ::Bool) at ./multi.jl:754
 in #remotecall_fetch#282(::Array{Any,1}, ::Function, ::Function, ::LocalProcess, ::String, ::Vararg{String,N}) at ./multi.jl:801
 in remotecall_fetch(::Function, ::LocalProcess, ::String, ::Vararg{String,N}) at ./multi.jl:801
 in #remotecall_fetch#284(::Array{Any,1}, ::Function, ::Function, ::Int64, ::String, ::Vararg{String,N}) at ./multi.jl:817
 in remotecall_fetch(::Function, ::Int64, ::String, ::Vararg{String,N}) at ./multi.jl:817
 in macro expansion at /Volumes/Lion/Users/jameson/Documents/julia/test/runtests.jl:36 [inlined]
 in (::##15#23{Array{Any,1}})() at ./task.jl:310
while loading /Volumes/Lion/Users/jameson/Documents/julia/test/stacktraces.jl, in expression starting on line 90
 in #remotecall_fetch#282(::Array{Any,1}, ::Function, ::Function, ::LocalProcess, ::String, ::Vararg{String,N}) at ./multi.jl:802
 in remotecall_fetch(::Function, ::LocalProcess, ::String, ::Vararg{String,N}) at ./multi.jl:801
 in #remotecall_fetch#284(::Array{Any,1}, ::Function, ::Function, ::Int64, ::String, ::Vararg{String,N}) at ./multi.jl:817
 in remotecall_fetch(::Function, ::Int64, ::String, ::Vararg{String,N}) at ./multi.jl:817
 in macro expansion at /Volumes/Lion/Users/jameson/Documents/julia/test/runtests.jl:36 [inlined]
 in (::##15#23{Array{Any,1}})() at ./task.jl:310
 in sync_end() at ./task.jl:276
 in macro expansion at ./task.jl:285 [inlined]
 in (::##11#19)() at /Volumes/Lion/Users/jameson/Documents/julia/test/runtests.jl:29
 in cd(::##11#19, ::String) at ./file.jl:48
 in include_from_node1(::String) at ./loading.jl:426
 in process_options(::Base.JLOptions) at ./client.jl:263
 in _start() at ./client.jl:319
while loading /Volumes/Lion/Users/jameson/Documents/julia/test/runtests.jl, in expression starting on line 13

[JeffBezanson]

I suppose it stands to reason that testing that backtraces report some function as inlined will not work when inlining is disabled :) I guess the test should look at the option flag and adjust what it tests for accordingly?

[vtjnash]

:) https://build.julialang.org/builders/coverage_ubuntu14.04-x64/builds/296