Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaLang/julia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d0deabd97cfd435f0edde84c8041f77ad0065253
Choose a base ref
..
head repository: JuliaLang/julia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 42d19c40ed699449914d9c6b3b16d10bdcdd7c59
Choose a head ref
Showing with 7 additions and 9 deletions.
  1. +1 −1 NEWS.md
  2. +4 −6 test/linalg/bidiag.jl
  3. +2 −2 test/linalg/dense.jl
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -136,7 +136,7 @@ Deprecated or removed
* The method `replace(s::AbstractString, pat, r, count)` with `count <= 0` is deprecated
in favor of `replace(s::AbstractString, pat, r, typemax(Int))` ([#22325]).

* `Bidiagonal` constructors have been re-factored to use a `Symbol` for the upper/lower
* `Bidiagonal` constructors now use a `Symbol` for the upper/lower
argument, instead of a `Bool` or a `Char` ([#22703]).


10 changes: 4 additions & 6 deletions test/linalg/bidiag.jl
Original file line number Diff line number Diff line change
@@ -186,12 +186,10 @@ srand(1)
end
end

@testset "round,float,trunc,ceil" begin
if elty <: BlasReal
for f in (round,float,trunc,ceil)
@test (f.(Int, T))::Bidiagonal == Bidiagonal(f.(Int, T.dv), f.(Int, T.ev), T.uplo)
@test (f.(T))::Bidiagonal == Bidiagonal(f.(T.dv), f.(T.ev), T.uplo)
end
if elty <: BlasReal
@testset "$f" for f in (floor, trunc, round, ceil)
@test (f.(Int, T))::Bidiagonal == Bidiagonal(f.(Int, T.dv), f.(Int, T.ev), T.uplo)
@test (f.(T))::Bidiagonal == Bidiagonal(f.(T.dv), f.(T.ev), T.uplo)
end
end

4 changes: 2 additions & 2 deletions test/linalg/dense.jl
Original file line number Diff line number Diff line change
@@ -150,11 +150,11 @@ bimg = randn(n,2)/2
A = diagm(d)
@test factorize(A) == Diagonal(d)
A += diagm(e,-1)
@test factorize(A) == Bidiagonal(d,e,:U)
@test factorize(A) == Bidiagonal(d,e,:L)
A += diagm(f,-2)
@test factorize(A) == LowerTriangular(A)
A = diagm(d) + diagm(e,1)
@test factorize(A) == Bidiagonal(d,e,:L)
@test factorize(A) == Bidiagonal(d,e,:U)
if eltya <: Real
A = diagm(d) + diagm(e,1) + diagm(e,-1)
@test full(factorize(A)) full(factorize(SymTridiagonal(d,e)))