From dfe5eeaa0620592493c5dc1ca0bfe923df69251e Mon Sep 17 00:00:00 2001 From: Takafumi Arakaki Date: Wed, 11 May 2022 10:11:23 -0400 Subject: [PATCH] Avoid "In the current implementation," conditional --- base/docs/basedocs.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/base/docs/basedocs.jl b/base/docs/basedocs.jl index b6a3bf4859c30..43892fda9673b 100644 --- a/base/docs/basedocs.jl +++ b/base/docs/basedocs.jl @@ -2758,10 +2758,10 @@ The syntax `@atomic! max(a().b, c)` returns `modifyproperty!(a(), :b, max, c, :sequentially_consistent))`, where the first argument must be a `getfield` expression and is modified atomically. -In the current implementation, the default implementation of `modifyproperty!` does not call -`convert` automatically and an exception is thrown if `op` returns a value that cannot be -stored in the field `f` of the object `x`. This is different from the behavior of the -default [`setproperty!`](@ref Base.setproperty!). +Invocation of `op(getproperty(x, f), v)` must return a value that can be stored in the field +`f` of the object `x` by default. In particular, unlike the default behavior of +[`setproperty!`](@ref Base.setproperty!), the `convert` function is not called +automatically. See also [`modifyfield!`](@ref Core.modifyfield!) and [`setproperty!`](@ref Base.setproperty!).