You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Sigh. Look at Base.GIT_VERSION_INFO.tagged_commit too. Looks like version_git.jl isn't getting built properly before it gets sent out to Launchpad. Luckily, I can just upload another batch of source debs.
The reason will be displayed to describe this comment to others. Learn more.
It's not the build machines clock that gets displayed there anyway. It's the committer time from the HEAD commit in git, so it would be @staticfloat's mashine time for this commit that is relevant (if version_git.jl was generated correctly).
It is also nice that we can use committer time, because it gets set to current time when we cheery-pick or rebase old commits (while author time stays as it the original commit).
a05f87b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do the ppa buildd machines have their clocks way off?
a05f87b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. Look at
Base.GIT_VERSION_INFO.tagged_commit
too. Looks likeversion_git.jl
isn't getting built properly before it gets sent out to Launchpad. Luckily, I can just upload another batch of source debs.a05f87b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the build machines clock that gets displayed there anyway. It's the committer time from the HEAD commit in git, so it would be @staticfloat's mashine time for this commit that is relevant (if version_git.jl was generated correctly).
It is also nice that we can use committer time, because it gets set to current time when we
cheery-pick
orrebase
old commits (while author time stays as it the original commit).a05f87b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed now.