Skip to content

Commit

Permalink
fix error msg test on 32-bit (#44441)
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth authored Mar 4, 2022
1 parent ffc5ffa commit 8c4ff55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/error.jl
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,6 @@ end
f44319(1)
catch e
s = sprint(showerror, e)
@test s == "MethodError: no method matching f44319(::Int64)\nClosest candidates are:\n f44319() at none:0"
@test s == "MethodError: no method matching f44319(::Int$(Sys.WORD_SIZE))\nClosest candidates are:\n f44319() at none:0"
end
end

5 comments on commit 8c4ff55

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on 8c4ff55 Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on 8c4ff55 Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems large, but is only 2 out of many combinations, so probably noise

["tuple", "index", ("sumelt", "NTuple", 3, "Float32")] | 2.00 (40%) ❌ | 1.00 (1%)
["tuple", "index", ("sumelt", "TupleWrapper", 8, "Float64")] | 1.88 (40%) ❌ | 1.00 (1%)

Please sign in to comment.