From 85075ad680544edb9279505a7a03e12ee5fc0419 Mon Sep 17 00:00:00 2001 From: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com> Date: Tue, 18 Jan 2022 15:09:40 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Ian Atol --- base/compiler/ssair/EscapeAnalysis/EAUtils.jl | 4 ++-- base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/base/compiler/ssair/EscapeAnalysis/EAUtils.jl b/base/compiler/ssair/EscapeAnalysis/EAUtils.jl index fb4499d01452a..c16a61d346f06 100644 --- a/base/compiler/ssair/EscapeAnalysis/EAUtils.jl +++ b/base/compiler/ssair/EscapeAnalysis/EAUtils.jl @@ -25,7 +25,7 @@ import InteractiveUtils: gen_call_with_extracted_types_and_kwargs Evaluates the arguments to the function call, determines its types, and then calls [`code_escapes`](@ref) on the resulting expression. As with `@code_typed` and its family, any of `code_escapes` keyword arguments can be given -as the optional arguments like `@code_escpase interp=myinterp myfunc(myargs...)`. +as the optional arguments like `@code_escapes interp=myinterp myfunc(myargs...)`. """ macro code_escapes(ex0...) return gen_call_with_extracted_types_and_kwargs(__module__, :code_escapes, ex0) @@ -36,7 +36,7 @@ end # @static if EA_AS_PKG code_escapes(f, argtypes=Tuple{}; [world], [interp]) -> result::EscapeResult code_escapes(tt::Type{<:Tuple}; [world], [interp]) -> result::EscapeResult -Runs the escape analysis on optimized IR of a genefic function call with the given type signature. +Runs the escape analysis on optimized IR of a generic function call with the given type signature. Note that the escape analysis runs after inlining, but before any other optimizations. ```julia diff --git a/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl b/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl index 417b8b3b84f9f..d56bb840a395e 100644 --- a/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl +++ b/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl @@ -42,7 +42,7 @@ end # XXX better to be IdSet{Int}? const FieldEscape = BitSet -const FieldEscapes = Vector{BitSet} +const FieldEscapes = Vector{FieldEscape} const ArrayEscapes = IdSet{Int} """