From 4b378adffb099abe5501e6cf1c99dd43be9c8717 Mon Sep 17 00:00:00 2001 From: "Viral B. Shah" Date: Sun, 14 Feb 2021 22:48:19 -0500 Subject: [PATCH] Link SuiteSparse against LBT when built in deps --- deps/openblas.mk | 2 +- deps/suitesparse.mk | 16 +++++----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/deps/openblas.mk b/deps/openblas.mk index 0b4f6b0aa83ae..166e1d4d65b89 100644 --- a/deps/openblas.mk +++ b/deps/openblas.mk @@ -119,7 +119,7 @@ endif endef $(eval $(call staged-install, \ openblas,$(OPENBLAS_SRC_DIR), \ - OPENBLAS_INSTALL,$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/$(LIBBLASNAME).$(SHLIB_EXT),, \ + OPENBLAS_INSTALL,$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT),, \ $$(INSTALL_NAME_CMD)libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT) $$(build_shlibdir)/libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT))) clean-openblas: diff --git a/deps/suitesparse.mk b/deps/suitesparse.mk index eda7a1c21c12d..5be8589875dc4 100644 --- a/deps/suitesparse.mk +++ b/deps/suitesparse.mk @@ -4,14 +4,12 @@ ifeq ($(USE_BLAS64), 1) UMFPACK_CONFIG := -DLONGBLAS='long long' CHOLMOD_CONFIG := -DLONGBLAS='long long' SPQR_CONFIG := -DLONGBLAS='long long' -ifeq ($(OPENBLAS_SYMBOLSUFFIX), 64_) UMFPACK_CONFIG += -DSUN64 CHOLMOD_CONFIG += -DSUN64 SPQR_CONFIG += -DSUN64 endif -endif -# Disable trying to link against libmetis +# Disable linking to libmetis CHOLMOD_CONFIG += -DNPARTITION ifneq ($(USE_BINARYBUILDER_SUITESPARSE), 1) @@ -23,7 +21,7 @@ SUITE_SPARSE_LIB := $(LDFLAGS) -L"$(abspath $(BUILDDIR))/SuiteSparse-$(SUITESPAR ifeq ($(OS), Darwin) SUITE_SPARSE_LIB += $(RPATH_ESCAPED_ORIGIN) endif -SUITESPARSE_MFLAGS := CC="$(CC)" CXX="$(CXX)" F77="$(FC)" AR="$(AR)" RANLIB="$(RANLIB)" BLAS="$(LIBBLAS)" LAPACK="$(LIBLAPACK)" \ +SUITESPARSE_MFLAGS := CC="$(CC)" CXX="$(CXX)" F77="$(FC)" AR="$(AR)" RANLIB="$(RANLIB)" BLAS="-L$(build_shlibdir) -lblastrampoline" LAPACK="-L$(build_shlibdir) -lblastrampoline" \ LDFLAGS="$(SUITE_SPARSE_LIB)" CFOPENMP="" CUDA=no CUDA_PATH="" \ UMFPACK_CONFIG="$(UMFPACK_CONFIG)" CHOLMOD_CONFIG="$(CHOLMOD_CONFIG)" SPQR_CONFIG="$(SPQR_CONFIG)" ifeq ($(OS),WINNT) @@ -53,11 +51,7 @@ $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-shlib.patch-applied: $(BU $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-winclang.patch-applied $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-shlib.patch-applied -ifeq ($(USE_SYSTEM_BLAS), 0) -$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/openblas -else ifeq ($(USE_SYSTEM_LAPACK), 0) -$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/lapack -endif +$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/blastrampoline $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/source-extracted $(MAKE) -C $(dir $<)SuiteSparse_config library config $(SUITESPARSE_MFLAGS) @@ -153,6 +147,6 @@ clean-suitesparse-wrapper: clean-suitesparse distclean-suitesparse-wrapper: distclean-suitesparse install-suitesparse-wrapper: install-suitesparse -# suitesparse depends on OpenBLAS -compile-suitesparse: | $(build_prefix)/manifest/openblas +# suitesparse depends on blastrampoline +compile-suitesparse: | $(build_prefix)/manifest/blastrampoline endif