From 43e73f2a8a74688e84c48af3ce4a5246f56e3f37 Mon Sep 17 00:00:00 2001 From: Cameron Prybol Date: Sat, 5 Nov 2016 07:33:50 -0700 Subject: [PATCH] address concerns that depwarn for transpose is unclear (#19205) * close https://github.com/JuliaLang/julia/issues/18320 * Update NEWS.md * Update deprecated.jl * Update deprecated.jl (cherry picked from commit f1544bc3a44e7a46f514a406658e3344aad8f207) --- NEWS.md | 5 +++-- base/deprecated.jl | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/NEWS.md b/NEWS.md index 56668e903d6b3..ec62a8bdb90cb 100644 --- a/NEWS.md +++ b/NEWS.md @@ -440,8 +440,9 @@ Deprecated or removed * Sparse matrix functions `etree`, `ereach`, `csc_permute`, and `symperm` have been moved to the [SuiteSparse.jl package](https://github.com/JuliaSparse/SuiteSparse.jl) ([#12231], [#17033]). - * The no-op `transpose` fallback has been deprecated. Consider introducing suitable - `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). + * The no-op `transpose` fallback for non-numeric arrays has been deprecated. Consider introducing suitable + `transpose` methods or calling `permutedims(x, (2, 1))` for matrices and `reshape(x, 1, length(x))` for + vectors. ([#13171], [#17075], [#17374]). * The following macros have been deprecated ([#16219]): * `@windows` is deprecated in favor of `is_windows()` diff --git a/base/deprecated.jl b/base/deprecated.jl index ab30d17f46fe7..1474efc625413 100644 --- a/base/deprecated.jl +++ b/base/deprecated.jl @@ -768,9 +768,10 @@ end # Deprecate no-op transpose fallback. Please see #13171 and #17075. function transpose(x) - depwarn(string("the no-op `transpose` fallback is deprecated, and no more specific ", - "`transpose` method for $(typeof(x)) exists. Consider `permutedims(x, [2, 1])` ", - "or writing a specific `transpose(x::$(typeof(x)))` method if appropriate."), + depwarn(string("the no-op `transpose` for non-numeric arrays is deprecated, ", + "and no specific `transpose` method for $(typeof(x)) exists. Use ", + "`permutedims(x, (2, 1))` for matrices and `reshape(x, 1, length(x))` for vectors, ", + "or write a specific `transpose(x::$(typeof(x)))` method if appropriate."), :transpose) return x end