Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New HistoricalStdlibVersions version is breaking the Pkg tests #3929

Closed
staticfloat opened this issue Jun 18, 2024 · 1 comment · Fixed by #3930
Closed

New HistoricalStdlibVersions version is breaking the Pkg tests #3929

staticfloat opened this issue Jun 18, 2024 · 1 comment · Fixed by #3930

Comments

@staticfloat
Copy link
Member

I'm confused; I tagged a v2.0 breaking version of HistoricalStdlibVersions, but it appears that new version is breaking existing Pkg tests. Is this compat entry insufficient?
@KristofferC
Copy link
Member

It seems Pkg adds HistoricalStdlibVersions.jl during testing in a temp env:

Pkg.jl/test/runtests.jl

Line 43 in db8ce89

Pkg.activate(; temp = true)

Which will not have that compat entry in it.

@IanButterworth IanButterworth mentioned this issue Jun 18, 2024
Merged
@KristofferC KristofferC mentioned this issue Jun 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HistoricalStdlibVersions install to version IanButterworth/Pkg.jl
2 participants
@staticfloat @KristofferC