Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the possibility of git cloning cli doing a shallow clone instead #2489

Open
ghost opened this issue Apr 6, 2021 · 2 comments
Open

Comments

@ghost
Copy link

ghost commented Apr 6, 2021

I've reported issue #40193 about the speed of cloning.

I understand there's improvements with cloning, it's now possible to use the git cli.

Is it possible for the git cli to do a shallow clone with git shallow clone with git clone --depth 1 --quiet $url $source_path instead?
Makes cloning much faster, and decreases the no of objects downloaded.

@StefanKarpinski
Copy link
Member

I believe that GitHub does not like shallow clones in the sense that they support them but it overloads their servers if too many people do it. If that's still the case, it would be rude of us to default to using a shallow clone. This also wouldn't be in a release prior to 1.7 and for that release, we're going to download tarballs and use them without unpacking them, which addresses the performance issues on Windows, allowing us to stop defaulting to using git clones at all there (at which point we could use a shallow clone since not that many people would be doing it).

@KristofferC
Copy link
Member

KristofferC commented Apr 6, 2021

Ref CocoaPods/CocoaPods#4989 (comment) and https://blog.cocoapods.org/Master-Spec-Repo-Rate-Limiting-Post-Mortem/.

KristofferC referenced this issue Apr 6, 2021
allow an option for using git CLI for git downloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants