Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qr factorisation method for nullspace #855

Open
gszep opened this issue May 27, 2021 · 1 comment · May be fixed by JuliaLang/julia#54519
Open

qr factorisation method for nullspace #855

gszep opened this issue May 27, 2021 · 1 comment · May be fixed by JuliaLang/julia#54519
Labels
feature Indicates new feature / enhancement requests

Comments

@gszep
Copy link

gszep commented May 27, 2021

I've opened this feature request based off the back of a thread on slack with @andreasnoack . Since QR is not as reliable as SVD in determining the rank, we could have an additional kwarg where the user provides an expected dimension of the nullspace. Roughly

function nullspace(A::AbstractMatrix; nullity::Int=0, kwargs...)

    if iszero(nullity) # default to SVD
        return nullspace(A;kwargs...)
   
    else 
        return qr(A').Q[:,end+1-nullity:end]
    end
end

A small test

A = randn(3)randn(3)'
nullity = 2 # expected nullity

A*nullspace(A)
A*qr(A').Q[:,end+1-nullity:end]
@andreasnoack
Copy link
Member

Ref #514

@brenhinkeller brenhinkeller added the feature Indicates new feature / enhancement requests label Nov 19, 2022
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates new feature / enhancement requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants