-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in out of place ldiv! #577
Comments
KristofferC
referenced
this issue
in JuliaLang/julia
Nov 12, 2018
* Fix for #29713 * Add tests for #29713 * Fix for #29713 * Copy the argument in the right branch * Copy the argument in the right branch - take 2 * Update qr.jl (cherry picked from commit 8d712f6)
61 tasks
tkf
referenced
this issue
in tkf/julia
Nov 21, 2018
* Fix for #29713 * Add tests for #29713 * Fix for #29713 * Copy the argument in the right branch * Copy the argument in the right branch - take 2 * Update qr.jl
KristofferC
referenced
this issue
in JuliaLang/julia
Dec 12, 2018
* Fix for #29713 * Add tests for #29713 * Fix for #29713 * Copy the argument in the right branch * Copy the argument in the right branch - take 2 * Update qr.jl (cherry picked from commit 8d712f6)
KristofferC
referenced
this issue
in JuliaLang/julia
Feb 11, 2019
* Fix for #29713 * Add tests for #29713 * Fix for #29713 * Copy the argument in the right branch * Copy the argument in the right branch - take 2 * Update qr.jl (cherry picked from commit 8d712f6)
KristofferC
referenced
this issue
in JuliaLang/julia
Feb 20, 2020
* Fix for #29713 * Add tests for #29713 * Fix for #29713 * Copy the argument in the right branch * Copy the argument in the right branch - take 2 * Update qr.jl (cherry picked from commit 8d712f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The out-of-place version of
ldiv!(Y, A, B)
incorrectly overwriteB
whenA
is a factorization of a non square matrix.The problem is in https://github.com/JuliaLang/julia/blob/367aab3dc15a5543bd14c73d1e38a3ce7e310f05/stdlib/LinearAlgebra/src/factorization.jl#L103 where
ldiv!(Y, A, B)
reduces to a call toldiv!(A,B)
which overwrites B.The text was updated successfully, but these errors were encountered: